Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deprecations by setting TILEDB_REMOVE_DEPRECATIONS flag #122

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

kounelisagis
Copy link
Member

In TileDB-Inc/TileDB-Py#2023, the TILEDB_REMOVE_DEPRECATIONS flag was introduced with a default value of True. This is a good practice to avoid using deprecated code. However, it caused the nightly build to fail (see build results) since the nightly tests TileDB-Py against the dev branch of the core, which has introduced some new deprecations.

This PR makes use of -Cskbuild.cmake.define.TILEDB_REMOVE_DEPRECATIONS=OFF to avoid the issue.

Copy link
Contributor

@dudoslav dudoslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I assume the only way to test this is to merge and let CI test it

@jdblischak
Copy link
Collaborator

I'm a little confused about the purpose of this flag. Isn't the purpose of nightly testing of dev TileDB-Py against dev TileDB to identify these types of breaking changes right away? If I understand this PR, now we only test for incompatibilities on Mondays. If that's the case, then why bother running on the other nights? Also, doesn't this make it harder to track down the source of the incompatibility, since now you have to search through a week of commits to TileDB instead of just a single day?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants