Remove temporary code to migrate tiledb-py-feedstock to scikit-build-core #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116
Closes #119
This PR fixes the nightly-build by removing the
script
field inmeta.yaml
since this repo adds custom build scripts.This mostly undoes the temporary patches for scikit-build-core (#114, #115, #116) now that the upstream feedstock has been migrated (conda-forge/tiledb-py-feedstock#232).
However, I had to keep the code that creates custom build scripts for two reasons:
script
fields fornot win
andwin
don't survive the round-trip import and export of the YAML recipeTILEDB_REMOVE_DEPRECATIONS
flag #122This is fine for now. Longer-term I would like to address these by:
build.sh
andbld.bat
. Usingscript
directly inmeta.yaml
is a convenience, but I don't believe it outweighs the burden on the nightly build setup scripts. It will be too easy for the feedstock and nightly builds to diverge without us realizing-Cskbuild.cmake.define.TILEDB_REMOVE_DEPRECATIONS
into the upstream feedstock or ultimately remove it once TileDB deprecations occur less oftenI tested this branch in a manual run. Below is the recipe diff. The important part is that both
script
fields are now deleted so that they don't interfere with the custombuild.sh
andbld.bat