Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define TILEDB_REMOVE_DEPRECATIONS macro for cc and remove deprecated code #2023

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

kounelisagis
Copy link
Member

This PR defines the TILEDB_REMOVE_DEPRECATIONS macro, resulting in an error when deprecated core code is used.
Also removes, deprecated code.

Related PRs:

Solves:
https://github.com/jdblischak/centralized-tiledb-nightlies/issues/14

tiledb/cc/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI passes. Thanks!

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants