Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deprecations by setting TILEDB_REMOVE_DEPRECATIONS flag #122

Merged
merged 4 commits into from
Aug 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions scripts/tiledb-py/update-recipe.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from ruamel.yaml import YAML
from yaml.constructor import ConstructorError
from yaml.scanner import ScannerError
from datetime import datetime

# Read values from plain-text files -------------------------------------------

Expand Down Expand Up @@ -63,8 +64,21 @@
yaml.dump(updated, f)

# (Temporary) Update build scripts for scikit-build-core
# Run with deprecation warnings on Mondays for forward-looking alerts.
remove_deprecations_value = "ON" if datetime.today().weekday() == 0 else "OFF"
ihnorton marked this conversation as resolved.
Show resolved Hide resolved

with open("tiledb-py-feedstock/recipe/build.sh", "w") as f:
f.write("TILEDB_PATH=${PREFIX} ${PYTHON} -m pip install --no-build-isolation --no-deps --ignore-installed -v .")
f.write(
f"TILEDB_PATH=${{PREFIX}} "
"${PYTHON} -m pip install "
f"-Cskbuild.cmake.define.TILEDB_REMOVE_DEPRECATIONS={remove_deprecations_value} "
"--no-build-isolation --no-deps --ignore-installed -v ."
)

with open("tiledb-py-feedstock/recipe/bld.bat", "w") as f:
f.write("set \"TILEDB_PATH=%LIBRARY_PREFIX%\" && %PYTHON% -m pip install --no-build-isolation --no-deps --ignore-installed -v .")
f.write(
f"set \"TILEDB_PATH=%LIBRARY_PREFIX%\" "
"&& %PYTHON% -m pip install "
f"-Cskbuild.cmake.define.TILEDB_REMOVE_DEPRECATIONS={remove_deprecations_value} "
"--no-build-isolation --no-deps --ignore-installed -v ."
)