-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue3 Migration #200
Vue3 Migration #200
Conversation
f9721e6
to
733d487
Compare
bee85e2
to
ccaf6ad
Compare
ff6bde7
to
52b3660
Compare
b5d771d
to
2fc873c
Compare
93db98a
to
663607a
Compare
…avigation. The problem is that the scroll is intiated before the components are updated. If the previous page was shorter than the next one, the browser might not scroll then. I am not sure exactly why this breaks now and didn't break in the vue2 version, but I think it is because Vue router is now async. The solution with a resizeObserver requires the least changes. Else we would need to add scrolling code to all views.
With the I tried to implement fading by the way described in the vue-router documentation, but it causes several bugs (probably due to some async problems). We can, in order to get this finally forward, make this a new PR. One thing I noticed for navigation is that the page is now reloaded when moving from back from an external page (Try going to MI, click on the IRIS link and then back. This is on Firefox/Chrome for me). I don't like it too much, but it's comparatively minor and probably not worth it to investigate or trivial to change. The only thing that we might want to address before merging is this bug I can see in Chrome only (icon line widths scaled by a factor of 2): Edit: I just noticed another bug: |
I cannot reproduce this. This icon looks identical between Firefox/Chrome and nav.tum.de/pr-200.nav.tum.de |
Okay, then it's probably a bug of my local Chrome version |
Should we ignore this until we have SSR ready, or change this in the language switcher? |
This PR migrates the frontend to Vue3:
The good part:
.env
/request-proxying. ⇒ no moreconfig.js
, or changes, that get accidentally committed.Caveats:
Things, this PR won't fix:
How to test?
To-dos:
/
(“main”)/api
/about/:id
/search
/view/:id
(“details”)Resolves #33
Resolves #213 (as this includes proper polyfills and does not depend on structuredClone)