[Cal-5] Added the calendar-modal #318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octycs
reviewed
Nov 28, 2022
| </div> | ||
| <div class="modal-body"> | ||
| <div class="content" id="modalCalendarContent"> | ||
| <iframe src="view_data.props.calendar_url"></iframe> |
There was a problem hiding this comment.
Suggested change
| <iframe src="view_data.props.calendar_url"></iframe> | |
| <iframe v-bind:src="view_data.props.calendar_url"></iframe> |
I think you need to use v-bind here
|
@octycs Thank you very much for the hint! Now is the problem that the iframe hasn't the permission to show the website. 😞 |
|
I have an API for the TUMonline calendar and will ask them if I can share it openly. |
|
blocked until #324 is done and merged |
CommanderStorm
changed the title
|
@Marius1501 I am closing this issue, as I don't see a way we can get this approach working. Any approaches in this way should be based on #200 and build as a component though, as that will be merge-ready soon and the calendar is a thing I think would be easier to develop+test this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #289
I added the modal for the calendar when clicking on the calendar icon. I used an iframe to display the TUMOnline website but the URL is not found. I don't know what's the problem because it is the same URL which is used to open the website.