-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback microservice #325
Conversation
8098e87
to
84ade37
Compare
I'm sorry that I've been quite inactive recently; I will try to give feedback until the end of the week. |
No worries: The only one of our PRs being a big deal is #317 and that one will only be reviewed on docs. (this will unblock #200 and make reviewing that one possible…) |
84ade37
to
dcb1597
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I only noticed that Firefox blocks Port 6000 for security reasons (See this old documentation). So maybe a different Port would be better.
Interesting, I did not notice this, as I don't test the APIs not in the browser. |
119f8c7
to
8d3a43a
Compare
This PR seperates feedback from our main API server.
Reasoning:
Hidden reasoning: this makes building additional feedback-features (e.g opening a PR on coordinate feedback 😉) less cluttered and better reviewable