Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback microservice #325

Merged
merged 6 commits into from
Dec 22, 2022
Merged

Feedback microservice #325

merged 6 commits into from
Dec 22, 2022

Conversation

CommanderStorm
Copy link
Member

This PR seperates feedback from our main API server.

Reasoning:

  • it has virtually no shared dependencies (natural fault line)
  • this way, we can deploy the feedback-API independently of the main server (both in time, scaling and reliability)
  • security: this way, we can increase our isolation

Hidden reasoning: this makes building additional feedback-features (e.g opening a PR on coordinate feedback 😉) less cluttered and better reviewable

@CommanderStorm CommanderStorm added the server Related to the backend/server label Dec 11, 2022
@CommanderStorm CommanderStorm self-assigned this Dec 11, 2022
@octycs
Copy link
Contributor

octycs commented Dec 12, 2022

I'm sorry that I've been quite inactive recently; I will try to give feedback until the end of the week.

@CommanderStorm
Copy link
Member Author

I'm sorry that I've been quite inactive recently

No worries:
None of the ready for review commits (#293, #282, #257, #325) are on any sort of timeline nor are urgent in any way.
None of these changes are application breaking features or improvements.
This is a marathon, not a sprint.

The only one of our PRs being a big deal is #317 and that one will only be reviewed on docs. (this will unblock #200 and make reviewing that one possible…)

Copy link
Contributor

@octycs octycs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I only noticed that Firefox blocks Port 6000 for security reasons (See this old documentation). So maybe a different Port would be better.

deployment/k3s/templates/ingress/ingress.yaml Outdated Show resolved Hide resolved
deployment/k3s/templates/service.yaml Outdated Show resolved Hide resolved
feedback/Dockerfile Outdated Show resolved Hide resolved
feedback/README.md Outdated Show resolved Hide resolved
feedback/README.md Outdated Show resolved Hide resolved
feedback/README.md Outdated Show resolved Hide resolved
feedback/src/main.rs Outdated Show resolved Hide resolved
@CommanderStorm
Copy link
Member Author

CommanderStorm commented Dec 22, 2022

Interesting, I did not notice this, as I don't test the APIs not in the browser.

@CommanderStorm CommanderStorm enabled auto-merge (squash) December 22, 2022 20:19
@CommanderStorm CommanderStorm merged commit d762608 into main Dec 22, 2022
@CommanderStorm CommanderStorm deleted the feedback-microservice branch December 22, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Related to the backend/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants