Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Overlays for StudiTUM Garching #282

Merged
merged 6 commits into from
Mar 16, 2023
Merged

Updated Overlays for StudiTUM Garching #282

merged 6 commits into from
Mar 16, 2023

Conversation

CommanderStorm
Copy link
Member

@CommanderStorm CommanderStorm commented Nov 9, 2022

This PR adds updated Maps for the StudiTUM Garching.
The core reasoning is, that the 3.OG is currently nor present.
During creation of this floor, I noticed that the other floors are not in the same style as the MW..
@octycs Is this change OK with you? (I can recreate your style for this Floor as well..)
Do you have any suggestions?

TODO:

  • Update the coordinates of this map

Resolves #276

@CommanderStorm CommanderStorm added the data This issue is related to the data collection and aggregation label Nov 9, 2022
@CommanderStorm CommanderStorm self-assigned this Nov 9, 2022
@octycs
Copy link
Contributor

octycs commented Nov 9, 2022

During creation of this floor, I noticed that the other floors are not in the same style as the MW..
@octycs Is this change OK with you? (I can recreate your style for this Floor as well..)

I did the different colors just to hint the floor colors of the building (you probably know). If this is rather irritating than helpful, or should be more explicit, we can switch to the default blue floor.

Honestly I would like to keep the doors. I assumed that the MW map was this way, because it would be way too tedious to draw all the doors (and other details). The Galileo EG map (I'm working on the 01 currently), as well as all the Roomfinder maps have also doors drawn.

There's one typo btw, on the bottom it's "NavigatTUM".

github-actions bot added a commit that referenced this pull request Mar 10, 2023
@CommanderStorm CommanderStorm force-pushed the studitum_gar branch 2 times, most recently from fb6d6dc to f1302de Compare March 11, 2023 18:28
github-actions bot added a commit that referenced this pull request Mar 11, 2023
@github-actions
Copy link
Contributor

👋 Thank you for contributing. A staging environment for this PR for this change will be available shortly

github-actions bot added a commit that referenced this pull request Mar 11, 2023
github-actions bot added a commit that referenced this pull request Mar 11, 2023
@github-actions
Copy link
Contributor

👋 Thank you for contributing. A staging environment for this PR for this change will be available shortly

github-actions bot added a commit that referenced this pull request Mar 11, 2023
Copy link
Contributor

@octycs octycs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged now from my point

@CommanderStorm CommanderStorm enabled auto-merge (squash) March 16, 2023 23:14
@CommanderStorm CommanderStorm merged commit 59aca02 into main Mar 16, 2023
@CommanderStorm CommanderStorm deleted the studitum_gar branch March 16, 2023 23:15
github-actions bot added a commit that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data This issue is related to the data collection and aggregation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Entry] StudiTUM Garching, Keller und Ebene 03 fehlen
2 participants