Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox esr is not supported [Bug] #213

Closed
joschahenningsen opened this issue Sep 26, 2022 · 4 comments · Fixed by #200 or #231
Closed

Firefox esr is not supported [Bug] #213

joschahenningsen opened this issue Sep 26, 2022 · 4 comments · Fixed by #200 or #231
Labels
bug Something isn't working

Comments

@joschahenningsen
Copy link
Member

Describe the bug
My os comes with the latest version of firefox esr (91.13.0esr) which was released in august: https://www.mozilla.org/en-US/firefox/91.13.0/releasenotes/ apparently the next esr release will be a 102.x upgrade but I suppose it might take a while to land.
With this version I get the error ReferenceError: structuredClone is not defined when opening navigatum. Presumably because the browser doesn't support some feature you use.

To Reproduce
Steps to reproduce the behavior:

  1. Use Firefox 91.13.0esr
  2. Open any room in navigatum

Expected behavior
The page should be displayed as intended.

Screenshots
image

Desktop (please complete the following information):

  • OS: Debian GNU/Linux 11 (bullseye)
  • Browser: firefox
  • Version: 91.13.0esr (64-bit)
@joschahenningsen joschahenningsen added the bug Something isn't working label Sep 26, 2022
@joschahenningsen
Copy link
Member Author

I just checked my updates after opening this issue. Turns out, 102.3.0esr is available now. 😄 🤦

Feel free to close this if you want, with the latest esr release it should not be too relevant anymore.

@CommanderStorm
Copy link
Member

This will be fixed once the migration to Vue3 is complete (#200)
In the mean time I have no idea, why https://github.com/TUM-Dev/navigatum/blob/2f470660a6e27d6c9a7a9af6f6cfd9054364c520/webclient/src/core.js#L77 does not bloody work.
core is definitively included here https://github.com/TUM-Dev/navigatum/blob/2f470660a6e27d6c9a7a9af6f6cfd9054364c520/webclient/src/index.html#L53

@octycs any ideas?

@CommanderStorm
Copy link
Member

Is defer the culprit?

@octycs
Copy link
Contributor

octycs commented Oct 1, 2022

@octycs any ideas?

I can also just guess ... maybe it has to do with the function declaration being in an if clause (see https://stackoverflow.com/a/10069457)? Then maybe window.structuredClone = function() { ... } could work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants