BUGFIX: Selenium Driver object reference was included in the browsing results for some reason #3642

bszollosinagy · 2023-05-01T21:30:05Z

There is really no need to return the reference to the Selenium driver along with the text summary and list of links.

Background

The browse_website AutoGPT command has had a harmless but ugly bug for a while now: It kept adding a reference to the Selenium Driver in the result.

Example (look at the last line)
System: Command browse_website returned: ("Answer gathered from website: The text does not provide information on the pros and cons of commercially available cherry cultivars. However, it does mention two varieties of sweet cherries, Dark Sweet Cherries and Rainier Cherry, and provides information on their nutrient content claims and health claims. The text also states that sweet cherries are available fresh, frozen, canned, and dried for good nutrition and convenience. If selecting fresh cherries, it is recommended to choose firm, red cherries with stems attached and to avoid soft or shriveled cherries. \n \n Links: ['Fruits & Veggies (https://fruitsandveggies.org/fruits-and-veggies/)', 'F&V Inspo (https://fruitsandveggies.org/series/)', 'Recipes (https://fruitsandveggies.org/recipes/)', 'Expert Advice (https://fruitsandveggies.org/expert-advice)', 'Contributors (https://fruitsandveggies.org/contributors/)']", <selenium.webdriver.chrome.webdriver.WebDriver (session="3ba34c5bb2d35f19d1c9777620807894")>)

Not really a big problem, but it does add some needless noise into AutoGPT's memory, and looks ugly too.

Changes

Will not return the Selenium driver object along with the results of the browsing.

Documentation

Test Plan

Tested by browsing with and without this change. As expected, no real problem is raised by simplifying the return value of the "browse_website" command.

PR Quality Checklist

My pull request is atomic and focuses on a single change.
I have thoroughly tested my changes with multiple different prompts.
I have considered potential risks and mitigations for my changes.
I have documented my changes clearly and comprehensively.
I have not snuck in any "extra" small tweaks changes

…ver along with the text summary and list of links.

vercel · 2023-05-01T21:30:09Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Ignored (Inspect)	Visit Preview		May 4, 2023 9:46pm

github-actions · 2023-05-04T19:54:52Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

bszollosinagy · 2023-05-04T19:55:51Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

Its only large because of the PyTest VCR Cassette

github-actions · 2023-05-04T21:01:24Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

…_browse_website

github-actions · 2023-05-04T21:18:58Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

codecov · 2023-05-04T21:25:13Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7d23452) 60.96% compared to head (51d658e) 60.96%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3642   +/-   ##
=======================================
  Coverage   60.96%   60.96%           
=======================================
  Files          72       72           
  Lines        3302     3302           
  Branches      542      542           
=======================================
  Hits         2013     2013           
  Misses       1151     1151           
  Partials      138      138

Impacted Files	Coverage Δ
autogpt/commands/web_selenium.py	`86.04% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…cholder commit to trigger re-testing due to some docker TCP timeout issue

github-actions · 2023-05-04T21:40:35Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-05-04T21:47:09Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

… results for some reason (Significant-Gravitas#3642) * * there is really no need to return the reference to the Selenium driver along with the text summary and list of links. * * removing unused second return value from browse_website() * * updated cassette * * updated YAML cassette for test_browse_website * * after requirements reinstall, another update YAML cassette for test_browse_website * * another update YAML cassette for test_browse_website, only as a placholder commit to trigger re-testing due to some docker TCP timeout issue * * another update YAML cassette for test_browse_website --------- Co-authored-by: batyu <batyu@localhost>

@collijk

* Feature/tighten up ci pipeline (#3700) * Fix docker volume mounts (#3710) Co-authored-by: Reinier van der Leer <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]> * Feature/enable intuitive logs for community challenge step 1 (#3695) * Feature/enable intuitive logs summarization (#3697) * Move task_complete command out of prompt (#3663) * feat: move task_complete command out of prompt * fix: formatting fixes * Add the shutdown command to the test agents * tests: update test vcrs --------- Co-authored-by: James Collins <[email protected]> * Allow users to Disable Commands via the .env (#3667) * Document Disabling command categories (#3669) * feat: move task_complete command out of prompt * fix: formatting fixes * feat: add command disabling * docs: document how to disable command categories * Enable denylist handling for plugins (#3688) Co-authored-by: Luke Kyohere <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]> * Fix call to `plugin.post_planning` (#3414) Co-authored-by: Nicholas Tindle <[email protected]> * create information retrieval challenge a (#3770) Co-authored-by: Richard Beales <[email protected]> * fix typos (#3798) * Update run.bat (#3783) Co-authored-by: Richard Beales <[email protected]> * Update run.sh (#3752) Co-authored-by: Richard Beales <[email protected]> * ADD: Bash block in the contributing markdown (#3701) Co-authored-by: Richard Beales <[email protected]> * BUGFIX: Selenium Driver object reference was included in the browsing results for some reason (#3642) * * there is really no need to return the reference to the Selenium driver along with the text summary and list of links. * * removing unused second return value from browse_website() * * updated cassette * * updated YAML cassette for test_browse_website * * after requirements reinstall, another update YAML cassette for test_browse_website * * another update YAML cassette for test_browse_website, only as a placholder commit to trigger re-testing due to some docker TCP timeout issue * * another update YAML cassette for test_browse_website --------- Co-authored-by: batyu <batyu@localhost> * Update CONTRIBUTING.md * Self feedback Improvement (#3680) * Improved `Self-Feedback` * minor tweak * Test: Updated `test_get_self_feedback.py` * community challenges in the wiki (#3764) * Update README.md * Update PULL_REQUEST_TEMPLATE.md Added link to wiki Contributing page * Add link to wiki Contributing page * fix * Add link to wiki page on Contributing * Implement Logging of User Input in logs/Debug Folder (#3867) * Adds USER_INPUT_FILE_NAME * Update agent.py * Update agent.py Log only if console_input is not the authorise_key * Reformatting * add information retrieval challenge to the wiki (#3876) * add code owners policy (#3981) * add code owners * added @ to codeowners * switched to team ownership * Memory Challenge C (#3908) * Memory Challenge C * Working cassettes * Doc fixes * Linting and doc fix * Updated cassette * One more cassette try --------- Co-authored-by: merwanehamadi <[email protected]> * memory challenge c inconsistent (#3985) * Improve & fix memory challenge docs. (#3989) Co-authored-by: Kaan Osmanagaoglu <[email protected]> * Feature/centralize prompt (#3990) Co-authored-by: xiao.hu <[email protected]> * Use correct reference to prompt_generator in autogpt/llm/chat.py (#4011) * fix typos (#3998) Co-authored-by: Minfeng Lu <[email protected]> Co-authored-by: Richard Beales <[email protected]> * fix typo in the getting started docs (#3997) Co-authored-by: Richard Beales <[email protected]> * Fix path to workspace directory in setup guide (#3927) Co-authored-by: Nicholas Tindle <[email protected]> * document that docker-compose 1.29.0 is minimally required (#3963) Co-authored-by: Nicholas Tindle <[email protected]> * Integrate pytest-xdist Plugin for Parallel and Concurrent Testing (#3870) * Adds pytest-parallel dependencies * Implement pytest-parallel for faster tests * Uses pytest-xdist * Auto number of workers processes * Update ci.yml --------- Co-authored-by: Nicholas Tindle <[email protected]> * explain temperature setting in env file (#4140) Co-authored-by: Richard Beales <[email protected]> * Catch JSON error in summary_memory.py (#3996) Co-authored-by: k-boikov <[email protected]> * Update duckduckgo dependency - min should be 2.9.5 (#4142) Co-authored-by: k-boikov <[email protected]> * Update Dockerfile - add missing scripts and plugins directories. (#3706) Co-authored-by: k-boikov <[email protected]> * Updated memory setup links (#3829) Co-authored-by: k-boikov <[email protected]> * Parse package versions so upgrades can be forced (#4149) * parse package versions so upgrades can be forced * better version from @collijk * fix typo in autopgt/agent/agent.py (#3747) Co-authored-by: merwanehamadi <[email protected]> Co-authored-by: Richard Beales <[email protected]> Co-authored-by: k-boikov <[email protected]> * Fix `milvus_memory_test.py` mock `Config` (#3424) Co-authored-by: k-boikov <[email protected]> * Implemented showing the number of preauthorised commands left. #1035 (#3322) Co-authored-by: mayubi <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]> Co-authored-by: k-boikov <[email protected]> * Challenge: Kubernetes and documentation (#4121) * challenge_kubes_and_readme * docs * testing * black and isort * revision * lint * comments * blackisort * docs * docs * deleting_cassette * suggestions * misspelling_errors --------- Co-authored-by: merwanehamadi <[email protected]> * Make sdwebui tests pass (when SD is running) (#3721) Co-authored-by: Nicholas Tindle <[email protected]> * Add Edge browser support using EdgeChromiumDriverManager (#3058) Co-authored-by: Nicholas Tindle <[email protected]> Co-authored-by: k-boikov <[email protected]> * Added --install-plugin-deps to Docker (#4151) Co-authored-by: Nicholas Tindle <[email protected]> * Feature/basic proxy (#4164) * basic proxy (#54) * basic proxy (#55) * basic proxy * basic proxy * basic proxy * basic proxy * add back double quotes * add more specific files * write file * basic proxy * Put back double quotes * test new CI (#4168) * test new CI * test new CI * remove double quotes * Feature/test new ci pipeline 2 (#4169) * test new CI * remove double quotes * make it a variable * make it a variable * Test New CI Pipeline (#4170) * introduce dummy prompt change * introduce dummy prompt change * empty commit * empty commit * empty commit * push to origin repo * add s to quote * Feature/fix rate limiting issue Step 1 (#4173) * temporarilly remove 3.11 * add back 3.11 (#4185) * Revert "Put back 3.11 until it's removed as a requirement" (#4191) --------- Co-authored-by: Reinier van der Leer <[email protected]> Co-authored-by: merwanehamadi <[email protected]> Co-authored-by: Peter Petermann <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]> Co-authored-by: James Collins <[email protected]> Co-authored-by: Luke K <[email protected]> Co-authored-by: Luke Kyohere <[email protected]> Co-authored-by: Robin Richtsfeld <[email protected]> Co-authored-by: RainRat <[email protected]> Co-authored-by: itsmarble <[email protected]> Co-authored-by: Ambuj Pawar <[email protected]> Co-authored-by: bszollosinagy <[email protected]> Co-authored-by: batyu <batyu@localhost> Co-authored-by: Pi <[email protected]> Co-authored-by: AbTrax <[email protected]> Co-authored-by: Andres Caicedo <[email protected]> Co-authored-by: Douglas Schonholtz <[email protected]> Co-authored-by: Kaan <[email protected]> Co-authored-by: Kaan Osmanagaoglu <[email protected]> Co-authored-by: xiao.hu <[email protected]> Co-authored-by: Tomasz Kasperczyk <[email protected]> Co-authored-by: minfeng-ai <[email protected]> Co-authored-by: Minfeng Lu <[email protected]> Co-authored-by: Shlomi <[email protected]> Co-authored-by: Itai Steinherz <[email protected]> Co-authored-by: Boostrix <[email protected]> Co-authored-by: Kristian Jackson <[email protected]> Co-authored-by: k-boikov <[email protected]> Co-authored-by: Eduardo Salinas <[email protected]> Co-authored-by: prom3theu5 <[email protected]> Co-authored-by: dominic-ks <[email protected]> Co-authored-by: andrey13771 <[email protected]> Co-authored-by: Marwand Ayubi <[email protected]> Co-authored-by: mayubi <[email protected]> Co-authored-by: Media <[email protected]> Co-authored-by: Cenny <[email protected]> Co-authored-by: Abdelkarim Habouch <[email protected]>

* there is really no need to return the reference to the Selenium dri…

f25a026

…ver along with the text summary and list of links.

github-actions bot added the size/s label May 1, 2023

batyu and others added 3 commits May 1, 2023 23:35

* removing unused second return value from browse_website()

6a936bb

Merge branch 'master' into bugfix_selenium_driver_reference

661082d

Merge branch 'master' into bugfix_selenium_driver_reference

677bc71

vercel bot temporarily deployed to Preview May 3, 2023 11:11 Inactive

Merge branch 'master' into bugfix_selenium_driver_reference

5b6a4c9

vercel bot temporarily deployed to Preview May 4, 2023 19:35 Inactive

* updated cassette

4d3a0d1

github-actions bot added size/xl and removed size/s labels May 4, 2023

waynehamadi previously approved these changes May 4, 2023

View reviewed changes

* updated YAML cassette for test_browse_website

52f68c6

bszollosinagy dismissed waynehamadi’s stale review via 52f68c6 May 4, 2023 21:01

* after requirements reinstall, another update YAML cassette for test…

e1e39f7

…_browse_website

* another update YAML cassette for test_browse_website, only as a pla…

47cea69

…cholder commit to trigger re-testing due to some docker TCP timeout issue

* another update YAML cassette for test_browse_website

51d658e

p-i- approved these changes May 4, 2023

View reviewed changes

p-i- merged commit ea08050 into Significant-Gravitas:master May 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUGFIX: Selenium Driver object reference was included in the browsing results for some reason #3642

BUGFIX: Selenium Driver object reference was included in the browsing results for some reason #3642

bszollosinagy commented May 1, 2023

vercel bot commented May 1, 2023 •

edited

Loading

github-actions bot commented May 4, 2023

bszollosinagy commented May 4, 2023

github-actions bot commented May 4, 2023

github-actions bot commented May 4, 2023

codecov bot commented May 4, 2023 •

edited

Loading

github-actions bot commented May 4, 2023

github-actions bot commented May 4, 2023

BUGFIX: Selenium Driver object reference was included in the browsing results for some reason #3642

BUGFIX: Selenium Driver object reference was included in the browsing results for some reason #3642

Conversation

bszollosinagy commented May 1, 2023

Background

Changes

Documentation

Test Plan

PR Quality Checklist

vercel bot commented May 1, 2023 • edited Loading

github-actions bot commented May 4, 2023

bszollosinagy commented May 4, 2023

github-actions bot commented May 4, 2023

github-actions bot commented May 4, 2023

codecov bot commented May 4, 2023 • edited Loading

Codecov Report

github-actions bot commented May 4, 2023

github-actions bot commented May 4, 2023

vercel bot commented May 1, 2023 •

edited

Loading

codecov bot commented May 4, 2023 •

edited

Loading