Fix docker volume mounts #3710

ppetermann · 2023-05-02T20:24:46Z

This is a quick-fix fixing #1513

Background

the Issue itself is that the release container is build only including "autogpt", while the documentations docker-compose.yml is trying to mount the local dir assuming its the source dir - which for most users wont be the case, thus the mount will overwrite the containers /app path with whats in local dir (not finding the autogpt module) and if its not mounted the scripts folder is missing.

Changes

this commit adresses both issues by adjusting the docker-compose.yml in the docs, as well as the Dockerfile to include scripts.

Now, this still creates a setup that wont be ideal for most users as they will struggle to get plugins and their dependencies in etc. it might make sense to provide an official project-template, similar, probably slightly adjusted to use official images, https://github.com/ppetermann/Auto-GPT-DockerSetup

(if needed I can help maintaining something)

PR Quality Checklist

My pull request is atomic and focuses on a single change.
I have thoroughly tested my changes with multiple different prompts.
I have considered potential risks and mitigations for my changes.
I have documented my changes clearly and comprehensively.
I have not snuck in any "extra" small tweaks changes

vercel · 2023-05-02T20:24:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Ignored (Inspect)	Visit Preview		May 2, 2023 11:03pm

codecov · 2023-05-02T20:30:39Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b0c6ed9) 59.89% compared to head (5e667b0) 59.89%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3710   +/-   ##
=======================================
  Coverage   59.89%   59.89%           
=======================================
  Files          69       69           
  Lines        3209     3209           
  Branches      535      535           
=======================================
  Hits         1922     1922           
  Misses       1149     1149           
  Partials      138      138

Impacted Files	Coverage Δ
autogpt/utils.py	`64.13% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/setup.md

it getting late here, good catch Co-authored-by: Reinier van der Leer <[email protected]>

Co-authored-by: Reinier van der Leer <[email protected]>

It looks like this default workspace location needs a minor fix after Significant-Gravitas#3710

Co-authored-by: Reinier van der Leer <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]>

@collijk

* Feature/tighten up ci pipeline (#3700) * Fix docker volume mounts (#3710) Co-authored-by: Reinier van der Leer <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]> * Feature/enable intuitive logs for community challenge step 1 (#3695) * Feature/enable intuitive logs summarization (#3697) * Move task_complete command out of prompt (#3663) * feat: move task_complete command out of prompt * fix: formatting fixes * Add the shutdown command to the test agents * tests: update test vcrs --------- Co-authored-by: James Collins <[email protected]> * Allow users to Disable Commands via the .env (#3667) * Document Disabling command categories (#3669) * feat: move task_complete command out of prompt * fix: formatting fixes * feat: add command disabling * docs: document how to disable command categories * Enable denylist handling for plugins (#3688) Co-authored-by: Luke Kyohere <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]> * Fix call to `plugin.post_planning` (#3414) Co-authored-by: Nicholas Tindle <[email protected]> * create information retrieval challenge a (#3770) Co-authored-by: Richard Beales <[email protected]> * fix typos (#3798) * Update run.bat (#3783) Co-authored-by: Richard Beales <[email protected]> * Update run.sh (#3752) Co-authored-by: Richard Beales <[email protected]> * ADD: Bash block in the contributing markdown (#3701) Co-authored-by: Richard Beales <[email protected]> * BUGFIX: Selenium Driver object reference was included in the browsing results for some reason (#3642) * * there is really no need to return the reference to the Selenium driver along with the text summary and list of links. * * removing unused second return value from browse_website() * * updated cassette * * updated YAML cassette for test_browse_website * * after requirements reinstall, another update YAML cassette for test_browse_website * * another update YAML cassette for test_browse_website, only as a placholder commit to trigger re-testing due to some docker TCP timeout issue * * another update YAML cassette for test_browse_website --------- Co-authored-by: batyu <batyu@localhost> * Update CONTRIBUTING.md * Self feedback Improvement (#3680) * Improved `Self-Feedback` * minor tweak * Test: Updated `test_get_self_feedback.py` * community challenges in the wiki (#3764) * Update README.md * Update PULL_REQUEST_TEMPLATE.md Added link to wiki Contributing page * Add link to wiki Contributing page * fix * Add link to wiki page on Contributing * Implement Logging of User Input in logs/Debug Folder (#3867) * Adds USER_INPUT_FILE_NAME * Update agent.py * Update agent.py Log only if console_input is not the authorise_key * Reformatting * add information retrieval challenge to the wiki (#3876) * add code owners policy (#3981) * add code owners * added @ to codeowners * switched to team ownership * Memory Challenge C (#3908) * Memory Challenge C * Working cassettes * Doc fixes * Linting and doc fix * Updated cassette * One more cassette try --------- Co-authored-by: merwanehamadi <[email protected]> * memory challenge c inconsistent (#3985) * Improve & fix memory challenge docs. (#3989) Co-authored-by: Kaan Osmanagaoglu <[email protected]> * Feature/centralize prompt (#3990) Co-authored-by: xiao.hu <[email protected]> * Use correct reference to prompt_generator in autogpt/llm/chat.py (#4011) * fix typos (#3998) Co-authored-by: Minfeng Lu <[email protected]> Co-authored-by: Richard Beales <[email protected]> * fix typo in the getting started docs (#3997) Co-authored-by: Richard Beales <[email protected]> * Fix path to workspace directory in setup guide (#3927) Co-authored-by: Nicholas Tindle <[email protected]> * document that docker-compose 1.29.0 is minimally required (#3963) Co-authored-by: Nicholas Tindle <[email protected]> * Integrate pytest-xdist Plugin for Parallel and Concurrent Testing (#3870) * Adds pytest-parallel dependencies * Implement pytest-parallel for faster tests * Uses pytest-xdist * Auto number of workers processes * Update ci.yml --------- Co-authored-by: Nicholas Tindle <[email protected]> * explain temperature setting in env file (#4140) Co-authored-by: Richard Beales <[email protected]> * Catch JSON error in summary_memory.py (#3996) Co-authored-by: k-boikov <[email protected]> * Update duckduckgo dependency - min should be 2.9.5 (#4142) Co-authored-by: k-boikov <[email protected]> * Update Dockerfile - add missing scripts and plugins directories. (#3706) Co-authored-by: k-boikov <[email protected]> * Updated memory setup links (#3829) Co-authored-by: k-boikov <[email protected]> * Parse package versions so upgrades can be forced (#4149) * parse package versions so upgrades can be forced * better version from @collijk * fix typo in autopgt/agent/agent.py (#3747) Co-authored-by: merwanehamadi <[email protected]> Co-authored-by: Richard Beales <[email protected]> Co-authored-by: k-boikov <[email protected]> * Fix `milvus_memory_test.py` mock `Config` (#3424) Co-authored-by: k-boikov <[email protected]> * Implemented showing the number of preauthorised commands left. #1035 (#3322) Co-authored-by: mayubi <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]> Co-authored-by: k-boikov <[email protected]> * Challenge: Kubernetes and documentation (#4121) * challenge_kubes_and_readme * docs * testing * black and isort * revision * lint * comments * blackisort * docs * docs * deleting_cassette * suggestions * misspelling_errors --------- Co-authored-by: merwanehamadi <[email protected]> * Make sdwebui tests pass (when SD is running) (#3721) Co-authored-by: Nicholas Tindle <[email protected]> * Add Edge browser support using EdgeChromiumDriverManager (#3058) Co-authored-by: Nicholas Tindle <[email protected]> Co-authored-by: k-boikov <[email protected]> * Added --install-plugin-deps to Docker (#4151) Co-authored-by: Nicholas Tindle <[email protected]> * Feature/basic proxy (#4164) * basic proxy (#54) * basic proxy (#55) * basic proxy * basic proxy * basic proxy * basic proxy * add back double quotes * add more specific files * write file * basic proxy * Put back double quotes * test new CI (#4168) * test new CI * test new CI * remove double quotes * Feature/test new ci pipeline 2 (#4169) * test new CI * remove double quotes * make it a variable * make it a variable * Test New CI Pipeline (#4170) * introduce dummy prompt change * introduce dummy prompt change * empty commit * empty commit * empty commit * push to origin repo * add s to quote * Feature/fix rate limiting issue Step 1 (#4173) * temporarilly remove 3.11 * add back 3.11 (#4185) * Revert "Put back 3.11 until it's removed as a requirement" (#4191) --------- Co-authored-by: Reinier van der Leer <[email protected]> Co-authored-by: merwanehamadi <[email protected]> Co-authored-by: Peter Petermann <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]> Co-authored-by: James Collins <[email protected]> Co-authored-by: Luke K <[email protected]> Co-authored-by: Luke Kyohere <[email protected]> Co-authored-by: Robin Richtsfeld <[email protected]> Co-authored-by: RainRat <[email protected]> Co-authored-by: itsmarble <[email protected]> Co-authored-by: Ambuj Pawar <[email protected]> Co-authored-by: bszollosinagy <[email protected]> Co-authored-by: batyu <batyu@localhost> Co-authored-by: Pi <[email protected]> Co-authored-by: AbTrax <[email protected]> Co-authored-by: Andres Caicedo <[email protected]> Co-authored-by: Douglas Schonholtz <[email protected]> Co-authored-by: Kaan <[email protected]> Co-authored-by: Kaan Osmanagaoglu <[email protected]> Co-authored-by: xiao.hu <[email protected]> Co-authored-by: Tomasz Kasperczyk <[email protected]> Co-authored-by: minfeng-ai <[email protected]> Co-authored-by: Minfeng Lu <[email protected]> Co-authored-by: Shlomi <[email protected]> Co-authored-by: Itai Steinherz <[email protected]> Co-authored-by: Boostrix <[email protected]> Co-authored-by: Kristian Jackson <[email protected]> Co-authored-by: k-boikov <[email protected]> Co-authored-by: Eduardo Salinas <[email protected]> Co-authored-by: prom3theu5 <[email protected]> Co-authored-by: dominic-ks <[email protected]> Co-authored-by: andrey13771 <[email protected]> Co-authored-by: Marwand Ayubi <[email protected]> Co-authored-by: mayubi <[email protected]> Co-authored-by: Media <[email protected]> Co-authored-by: Cenny <[email protected]> Co-authored-by: Abdelkarim Habouch <[email protected]>

hughdidit · 2023-11-05T18:57:48Z

To anyone that has added the AutoGPT plugins, the install process recreates this issue and you will need to go back into your docker-compose.yml file and comment out the line:

./:/app

in services: auto-gpt: volumes: object.

Pwuts · 2023-11-16T14:34:31Z

@hughdidit can you elaborate on how that fixes the problem?

hughdidit · 2023-11-17T04:02:57Z

@hughdidit can you elaborate on how that fixes the problem?

Sure. The problem and solution is actually described in the opening statement of this ticket by ppetermann so if you want a more in depth answer as to why it solves the problem I suggest contacting him. But, as described the app folder in Docker was getting overwritten by docker-compose.yml in the AutoGPT app and that was removed. The people at the plugins dept of AutoGPT didn't get that memo apparently because their docker-compose.yml reinstates the same problem.

That line of code in the docker-compose.yml is not needed and could probably be deleted but just comment it out to be on the safe side.

Pwuts and others added 2 commits May 2, 2023 16:53

Release v0.3.0 (Significant-Gravitas#3683)

d8f5cdb

this addresses the issues mentioned in Significant-Gravitas#1513

ce9ca90

github-actions bot added the size/s label May 2, 2023

vercel bot temporarily deployed to Preview May 2, 2023 20:25 Inactive

Pwuts changed the base branch from stable to master May 2, 2023 21:09

Pwuts requested changes May 2, 2023

View reviewed changes

docs/setup.md Show resolved Hide resolved

Pwuts changed the title ~~this addresses the issues mentioned in #1513~~ Fix docker volume mounts May 2, 2023

Pwuts self-assigned this May 2, 2023

Pwuts added the docker label May 2, 2023

Pwuts linked an issue May 2, 2023 that may be closed by this pull request

Unable to run built docker container: No module named autogpt #1513

Closed

1 task

adding a few mount examples

65da391

github-actions bot added size/m and removed size/s labels May 2, 2023

vercel bot temporarily deployed to Preview May 2, 2023 21:47 Inactive

if there is no volumes active, this needs to be commented out

a58ec82

vercel bot temporarily deployed to Preview May 2, 2023 21:50 Inactive

Pwuts reviewed May 2, 2023

View reviewed changes

docs/setup.md Outdated Show resolved Hide resolved

Pwuts reviewed May 2, 2023

View reviewed changes

docs/setup.md Outdated Show resolved Hide resolved

Pwuts reviewed May 2, 2023

View reviewed changes

docs/setup.md Outdated Show resolved Hide resolved

Update docs/setup.md

f2d8a6b

it getting late here, good catch Co-authored-by: Reinier van der Leer <[email protected]>

vercel bot temporarily deployed to Preview May 2, 2023 21:55 Inactive

Update docs/setup.md

7b59daa

Co-authored-by: Reinier van der Leer <[email protected]>

vercel bot temporarily deployed to Preview May 2, 2023 22:05 Inactive

Update docs/setup.md

6f5fc04

Co-authored-by: Reinier van der Leer <[email protected]>

vercel bot temporarily deployed to Preview May 2, 2023 22:09 Inactive

add data folder / move current_bulletin.md to data folder

2fa3936

vercel bot temporarily deployed to Preview May 2, 2023 22:21 Inactive

satisfy black

5658b96

ppetermann requested a review from Pwuts May 2, 2023 22:40

Pwuts approved these changes May 2, 2023

View reviewed changes

Pwuts requested a review from ntindle May 2, 2023 22:53

ntindle assigned ntindle and unassigned Pwuts May 2, 2023

ntindle approved these changes May 2, 2023

View reviewed changes

Merge branch 'master' into stable

5e667b0

ntindle added this to the v0.3.1 Release milestone May 2, 2023

ntindle merged commit 479c746 into Significant-Gravitas:master May 2, 2023

This was referenced May 3, 2023

ModuleNotFoundError: No module named 'scripts' #3704

Closed

"docker-compose run" ends with "/usr/local/bin/python: No module named autogpt" #3733

Closed

Pwuts mentioned this pull request May 4, 2023

Improve chunking and chunk handling #38

Closed

rlywtf pushed a commit to rlywtf/AutoGPT that referenced this pull request May 5, 2023

Update setup.md

1e98e0b

It looks like this default workspace location needs a minor fix after Significant-Gravitas#3710

rlywtf mentioned this pull request May 5, 2023

Update setup.md auto_gpt_workspace mount #3826

Closed

5 tasks

dschonholtz pushed a commit to dschonholtz/Auto-GPT that referenced this pull request May 6, 2023

Fix docker volume mounts (Significant-Gravitas#3710)

44e30f3

Co-authored-by: Reinier van der Leer <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]>

RealHossie pushed a commit to RealHossie/Auto-GPT-Chinese that referenced this pull request May 6, 2023

Fix docker volume mounts (Significant-Gravitas#3710)

bf8e9d5

Co-authored-by: Reinier van der Leer <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]>

jaimevalero pushed a commit to jaimevalero/Auto-GPT that referenced this pull request May 14, 2023

Fix docker volume mounts (Significant-Gravitas#3710)

299c259

Co-authored-by: Reinier van der Leer <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix docker volume mounts #3710

Fix docker volume mounts #3710

ppetermann commented May 2, 2023

vercel bot commented May 2, 2023 •

edited

Loading

codecov bot commented May 2, 2023 •

edited

Loading

hughdidit commented Nov 5, 2023 •

edited

Loading

Pwuts commented Nov 16, 2023

hughdidit commented Nov 17, 2023 •

edited

Loading

Fix docker volume mounts #3710

Fix docker volume mounts #3710

Conversation

ppetermann commented May 2, 2023

Background

Changes

PR Quality Checklist

vercel bot commented May 2, 2023 • edited Loading

codecov bot commented May 2, 2023 • edited Loading

Codecov Report

hughdidit commented Nov 5, 2023 • edited Loading

Pwuts commented Nov 16, 2023

hughdidit commented Nov 17, 2023 • edited Loading

vercel bot commented May 2, 2023 •

edited

Loading

codecov bot commented May 2, 2023 •

edited

Loading

hughdidit commented Nov 5, 2023 •

edited

Loading

hughdidit commented Nov 17, 2023 •

edited

Loading