Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Selenium Driver object reference was included in the browsing results for some reason #3642

Merged
merged 10 commits into from
May 4, 2023
Merged

BUGFIX: Selenium Driver object reference was included in the browsing results for some reason #3642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f25a026
* there is really no need to return the reference to the Selenium dr…
May 1, 2023
6a936bb
* removing unused second return value from browse_website()
May 1, 2023
661082d
Merge branch 'master' into bugfix_selenium_driver_reference
bszollosinagy May 2, 2023
677bc71
Merge branch 'master' into bugfix_selenium_driver_reference
bszollosinagy May 3, 2023
5b6a4c9
Merge branch 'master' into bugfix_selenium_driver_reference
bszollosinagy May 4, 2023
4d3a0d1
* updated cassette
May 4, 2023
52f68c6
* updated YAML cassette for test_browse_website
May 4, 2023
e1e39f7
* after requirements reinstall, another update YAML cassette for test…
bszollosinagy May 4, 2023
47cea69
* another update YAML cassette for test_browse_website, only as a pla…
bszollosinagy May 4, 2023
51d658e
* another update YAML cassette for test_browse_website
bszollosinagy May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions autogpt/commands/web_selenium.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
'"url": "<url>", "question": "<what_you_want_to_find_on_website>"',
)
@validate_url
def browse_website(url: str, question: str) -> tuple[str, WebDriver]:
def browse_website(url: str, question: str) -> str:
"""Browse a website and return the answer and links to the user

Args:
Expand All @@ -50,7 +50,7 @@ def browse_website(url: str, question: str) -> tuple[str, WebDriver]:
# These errors are often quite long and include lots of context.
# Just grab the first line.
msg = e.msg.split("\n")[0]
return f"Error: {msg}", None
return f"Error: {msg}"

add_header(driver)
summary_text = summary.summarize_text(url, text, question, driver)
Expand All @@ -60,7 +60,7 @@ def browse_website(url: str, question: str) -> tuple[str, WebDriver]:
if len(links) > 5:
links = links[:5]
close_browser(driver)
return f"Answer gathered from website: {summary_text} \n \n Links: {links}", driver
return f"Answer gathered from website: {summary_text} \n \n Links: {links}"


def scrape_text_with_selenium(url: str) -> tuple[WebDriver, str]:
Expand Down
Loading