Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

646 notebooks install #1187

Merged
merged 6 commits into from
Dec 6, 2019
Merged

646 notebooks install #1187

merged 6 commits into from
Dec 6, 2019

Conversation

glindsell
Copy link
Contributor

@glindsell glindsell commented Dec 3, 2019 •
edited
Loading

(Replaces #1180)

#646

  • New setup notebook created and referenced in example notebooks.

  • Testing of notebooks raised the following issues:

#1177

#1178

#1179

#473 is also still appearing in https://github.com/SeldonIO/seldon-core/blob/master/notebooks/helm_examples.ipynb

@glindsell glindsell requested a review from axsaucedo December 3, 2019 16:19
@glindsell glindsell mentioned this pull request Dec 3, 2019
Closed
@glindsell glindsell requested review from ryandawsonuk and removed request for adriangonz and arnaudvl December 3, 2019 16:20
@glindsell glindsell self-assigned this Dec 3, 2019
@glindsell glindsell mentioned this pull request Dec 4, 2019
Merged
@ukclivecox ukclivecox added this to the 1.0 milestone Dec 5, 2019
@glindsell glindsell mentioned this pull request Dec 6, 2019
Closed
@seldondev
Copy link
Collaborator

Fri Dec 6 11:46:03 UTC 2019
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1187/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1187 --build=4

@seldondev
Copy link
Collaborator

Fri Dec 6 11:46:14 UTC 2019
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1187/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1187 --build=5

@glindsell
Copy link
Contributor Author

@ryandawsonuk please take a look at changes discussed today re: bringing helm commands into setup notebook.

@ryandawsonuk
Copy link
Contributor

/lgtm
/approve

@seldondev seldondev added the lgtm label Dec 6, 2019
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Dec 6 15:09:32 UTC 2019
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1187/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1187 --build=7

@seldondev
Copy link
Collaborator

Fri Dec 6 15:09:38 UTC 2019
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1187/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1187 --build=6

@ryandawsonuk ryandawsonuk merged commit 8889eb1 into SeldonIO:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo Awaiting requested review from axsaucedo

@ryandawsonuk ryandawsonuk Awaiting requested review from ryandawsonuk

Assignees
No one assigned
Labels
approved lgtm size/XXL
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@glindsell @seldondev @ryandawsonuk @ukclivecox