Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#646 Move setup outside example notebooks #1180

Closed
wants to merge 1 commit into from
Closed

#646 Move setup outside example notebooks #1180

wants to merge 1 commit into from

Conversation

glindsell
Copy link
Contributor

@glindsell glindsell commented Dec 2, 2019

#646

  • New setup notebook created and referenced in example notebooks.

  • Testing of notebooks raised the following issues:

#1177

#1178

#1179

#473 is also still appearing in https://github.com/SeldonIO/seldon-core/blob/master/notebooks/helm_examples.ipynb

Signed-off-by: glindsell [email protected]

@glindsell glindsell added this to the 1.0 milestone Dec 2, 2019
@glindsell glindsell self-assigned this Dec 2, 2019
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ryandawsonuk

If they are not already assigned, you can assign the PR to them by writing /assign @ryandawsonuk in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

@glindsell nice one! RIgh now you seem to have covered the notebooks folder, but there are quite a few more in the examples folder that would also need modifying (that's where the larger number of examples live)

@glindsell glindsell mentioned this pull request Dec 3, 2019
@glindsell
Copy link
Contributor Author

Replaced by #1187

@glindsell
Copy link
Contributor Author

glindsell commented Dec 3, 2019

@axsaucedo This is now replaced by #1187 and have created separate issue for Example Notebooks #1154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants