Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow example fails in Istio notebook #1179

Closed
glindsell opened this issue Dec 2, 2019 · 4 comments
Closed

Shadow example fails in Istio notebook #1179

glindsell opened this issue Dec 2, 2019 · 4 comments
Labels
Milestone

Comments

@glindsell
Copy link
Contributor

https://github.com/SeldonIO/seldon-core/blob/master/notebooks/istio_example.ipynb

shadow

@ryandawsonuk
Copy link
Contributor

ryandawsonuk commented Dec 11, 2019

Am confused by this as @SMV and I have seen the grafana dashboards go up on the shadow predictor when running a load test with a shadow. And the load test does use the external endpoint. Tried to check this in the notebook using kind and the istio 1.4.2 but then realised that it assumes an external LoadBalancer. I tried port-forwarding with kubectl port-forward -n istio-system svc/istio-ingressgateway 8080:80 but struggling to get the seldon_client to work with that.

@SMV
Copy link

SMV commented Dec 11, 2019

@ryandawsonuk, I am also confused by this, as I haven't worked on this a day in my life. Think you tagged the wrong github account. Good luck.

@ryandawsonuk
Copy link
Contributor

Yes wrong account, sorry I meant @SachinVarghese

@axsaucedo axsaucedo added this to the 1.1 milestone Jan 16, 2020
@ukclivecox
Copy link
Contributor

Reopen if still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants