Merge pull request #1187 from glindsell/646-notebooks-install

646 notebooks install
SeldonIO · Dec 6, 2019 · 8889eb1 · 8889eb1
2 parents 4a5f4af + 58f4a2c
commit 8889eb1
Show file tree

Hide file tree

Showing 9 changed files with 3,004 additions and 4,055 deletions.
diff --git a/notebooks/benchmark_simple_model.ipynb b/notebooks/benchmark_simple_model.ipynb
diff --git a/notebooks/explainer_examples.ipynb b/notebooks/explainer_examples.ipynb
diff --git a/notebooks/helm_examples.ipynb b/notebooks/helm_examples.ipynb
diff --git a/notebooks/istio_example.ipynb b/notebooks/istio_example.ipynb
diff --git a/notebooks/max_grpc_msg_size.ipynb b/notebooks/max_grpc_msg_size.ipynb
diff --git a/notebooks/seldon_client.ipynb b/notebooks/seldon_client.ipynb
@@ -25,7 +25,6 @@
    "outputs": [],
    "source": [
     "INGRESS_HOST=!kubectl -n istio-system get service istio-ingressgateway -o jsonpath='{.status.loadBalancer.ingress[0].ip}'\n",
-    "INGRESS_PORT=!kubectl -n istio-system get service istio-ingressgateway -o jsonpath='{.spec.ports[?(@.name==\"http2\")].port}'\n",
     "ISTIO_GATEWAY=INGRESS_HOST[0]"
    ]
   },
@@ -58,16 +57,11 @@
    "cell_type": "markdown",
    "metadata": {},
    "source": [
-    "You will need to install Seldon and ensure its using the kubeflow gateway"
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "!helm install ../helm-charts/seldon-core-operator --name seldon-core --set istio.enabled=true --set istio.gateway=kubeflow-gateway --set usageMetrics.enabled=true   --namespace seldon-system"
+    "## Start Seldon Core\n",
+    "\n",
+    "Follow the instructions to [Install Seldon Core](seldon_core_setup.ipynb#Install-Seldon-Core) with [Istio Ingress](seldon_core_setup.ipynb#Istio).\n",
+    "\n",
+    "**Note** When running helm install for this example you will need to set the istio.gateway flag to kubeflow-gateway (```--set istio.gateway=kubeflow-gateway```)."
    ]
   },
   {
@@ -134,16 +128,11 @@
    "cell_type": "markdown",
    "metadata": {},
    "source": [
-    "You will need to install Seldon using the gateway `mygateway` used in the example."
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "!helm install ../helm-charts/seldon-core-operator --name seldon-core --set istio.enabled=true --set istio.gateway=mygateway --set usageMetrics.enabled=true   --namespace seldon-system"
+    "## Start Seldon Core\n",
+    "\n",
+    "Follow the instructions to [Install Seldon Core](seldon_core_setup.ipynb#Install-Seldon-Core) with [Istio Ingress](seldon_core_setup.ipynb#Istio).\n",
+    "\n",
+    "**Note** When running ```helm install``` for this example you will need to set the ```istio.gateway``` flag to ```mygateway``` (```--set istio.gateway=mygateway```) used in the example."
    ]
   },
   {
@@ -183,21 +172,12 @@
   {
    "cell_type": "code",
    "execution_count": null,
-   "metadata": {
-    "scrolled": true
-   },
+   "metadata": {},
    "outputs": [],
    "source": [
     "r = sc.predict(gateway=\"istio\",transport=\"grpc\",shape=(1,4))\n",
     "print(r)"
    ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {},
-   "outputs": [],
-   "source": []
   }
  ],
  "metadata": {
@@ -216,7 +196,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.6.8"
+   "version": "3.7.5"
   }
  },
  "nbformat": 4,