Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedstock rc branch management in do-nothing script #5515

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description


Consult Iris pull request check list

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (54ad9be) 89.68% compared to head (75d2c8e) 89.44%.

❗ Current head 75d2c8e differs from pull request most recent head 91458ea. Consider uploading reports for the commit 91458ea to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5515      +/-   ##
==========================================
- Coverage   89.68%   89.44%   -0.25%     
==========================================
  Files          90       89       -1     
  Lines       22818    22597     -221     
  Branches     5446     5390      -56     
==========================================
- Hits        20465    20211     -254     
- Misses       1619     1639      +20     
- Partials      734      747      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tools/release_do_nothing.py Outdated Show resolved Hide resolved
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks reasonable, no other problems I can seee

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trexfeathers LGTM 👍

@pp-mo pp-mo merged commit eafefdb into SciTools:main Dec 1, 2023
16 checks passed
@trexfeathers
Copy link
Contributor Author

Many thanks @bjlittle and @pp-mo 🥂

tkknight added a commit to tkknight/iris that referenced this pull request Dec 4, 2023
* 'numpydocs1' of github.com:tkknight/iris:
  Feedstock rc branch management in do-nothing script (SciTools#5515)
  Relocated the Technical Papers documentation to Further Topics.  (SciTools#5602)
  Fix pp save of realization coordinate (SciTools#5568)
  Bump actions/checkout from 3 to 4 (SciTools#5460)
  Bump actions/github-script from 6 to 7 (SciTools#5580)
  Bump conda-incubator/setup-miniconda from 2 to 3 (SciTools#5607)
  CI: specify matplotlib-base (SciTools#5606)
tkknight added a commit to tkknight/iris that referenced this pull request Dec 6, 2023
* main:
  DOCS: Numpydocs1 (SciTools#5578)
  add links to scitools-classroom repo. (SciTools#5609)
  Feedstock rc branch management in do-nothing script (SciTools#5515)
  Relocated the Technical Papers documentation to Further Topics.  (SciTools#5602)
  Fix pp save of realization coordinate (SciTools#5568)
  Bump actions/checkout from 3 to 4 (SciTools#5460)
  Bump actions/github-script from 6 to 7 (SciTools#5580)
  Bump conda-incubator/setup-miniconda from 2 to 3 (SciTools#5607)
  CI: specify matplotlib-base (SciTools#5606)
  Mergeback of `FEATURE_chunk_control` branch (SciTools#5588)
  [CI Bot] environment lockfiles auto-update (SciTools#5547)
  Mergeback of "Feature _split_attrs" branch (SciTools#5152)
  add whatsnew (SciTools#5596)
  Refactor area weighted regridding, improve performance (SciTools#5543)
  Allowing exemption to axis guessing on coords (SciTools#5551)
@trexfeathers trexfeathers deleted the feedstock_rc branch May 3, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants