Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedstock rc branch management in do-nothing script #5515

Merged
merged 5 commits into from
Dec 1, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/src/whatsnew/latest.rst
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

.. include:: ../common_links.inc

|iris_version| |build_date| [unreleased]
Expand Down Expand Up @@ -93,6 +94,11 @@ This document explains the changes made to Iris for this release
#. `@trexfeathers`_ adapted benchmarking to work with ASV ``>=v0.6`` by no
longer using the ``--strict`` argument. (:pull:`5496`)

#. `@trexfeathers`_ and `@pp-mo`_ improved how the conda-forge feedstock
release candidate branch is managed, via:
:doc:`../developers_guide/release_do_nothing`.
(:pull:`5515`)




Expand Down
28 changes: 27 additions & 1 deletion tools/release_do_nothing.py
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,33 @@ def update_conda_forge(
_wait_for_done(message)

if is_release_candidate:
upstream_branch = "release-candidate"
# We chose this odd handling of release candidate branches because
pp-mo marked this conversation as resolved.
Show resolved Hide resolved
# a persistent branch will gradually diverge as `main` receives
# automatic and manual maintenance (where recreating these on another
# branch is often beyond Iris dev expertise). Advised practice from
# conda-forge is also liable to evolve over time. Since there is no
# benefit to a continuous Git history on the release candidate branch,
# the simplest way to keep it aligned with best practice is to
# regularly create a fresh branch from `main`.

date_string = datetime.today().strftime("%Y%m%d")
message = (
"Visit the conda-forge feedstock branches page:\n"
"https://github.com/conda-forge/iris-feedstock/branches\n\n"
"Archive the existing release candidate (or rc) branch by "
f"appending _{date_string} to its name.\n"
f"e.g. rc_{date_string}\n\n"
f"({__file__} includes an explanation of this in the comments)."
)
_wait_for_done(message)

message = (
"Follow the latest conda-forge guidance for creating a new "
"release candidate branch from the `main` branch:\n"
"https://conda-forge.org/docs/maintainer/knowledge_base.html#pre-release-builds\n\n"
"Config file(s) should point to the `rc_iris` label.\n"
)
upstream_branch = _get_input(message, "Input the name of your new branch")
else:
upstream_branch = "main"

Expand Down
Loading