Allowing exemption to axis guessing on coords #5551

HGWright · 2023-10-25T12:56:04Z

🚀 Pull Request

Description

This PR adds a coordinate property guess_coord that forces guess_coord_axis to return None.

Tests for guess_coord and guess_coord_axis added.

Closes #5003

for more information, see https://pre-commit.ci

lib/iris/coords.py

lib/iris/util.py

for more information, see https://pre-commit.ci

* 'guess_coord' of github.com:HGWright/iris: [pre-commit.ci] auto fixes from pre-commit.com hooks precommit

bjlittle

@HGWright It's taking shape, so thanks for persevering 💯

Here's some initial suggestions 👍

lib/iris/coords.py

lib/iris/util.py

lib/iris/coords.py

for more information, see https://pre-commit.ci

codecov · 2023-11-09T14:24:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80c1792) 89.44% compared to head (b01f3f8) 89.45%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5551   +/-   ##
=======================================
  Coverage   89.44%   89.45%           
=======================================
  Files          89       89           
  Lines       22587    22603   +16     
  Branches     5385     5389    +4     
=======================================
+ Hits        20203    20219   +16     
  Misses       1638     1638           
  Partials      746      746

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

for more information, see https://pre-commit.ci

* 'guess_coord' of github.com:HGWright/iris: [pre-commit.ci] auto fixes from pre-commit.com hooks precommit merge

bjlittle

@HGWright This is looking really good.

Just a few minor actions to service, then we can bank this 👍

lib/iris/tests/unit/util/test_guess_coord_axis.py

lib/iris/tests/unit/coords/test_Coord.py

lib/iris/tests/unit/util/test_guess_coord_axis.py

lib/iris/util.py

bjlittle · 2023-11-17T10:30:06Z

@HGWright You also need to add a whatsnew entry, thanks 👍

bjlittle · 2023-11-17T10:31:35Z

@HGWright Could you also raise an issue to capture the need to document these changes.

We can action that separately, rather than bloat the scope of this pull-request.

for more information, see https://pre-commit.ci

* 'guess_coord' of github.com:HGWright/iris: [pre-commit.ci] auto fixes from pre-commit.com hooks add precommit changes

for more information, see https://pre-commit.ci

* 'guess_coord' of github.com:HGWright/iris: (82 commits) [pre-commit.ci] auto fixes from pre-commit.com hooks [pre-commit.ci] pre-commit autoupdate (SciTools#5579) Relicense to from LGPL-3 to BSD-3 (SciTools#5577) Allow `add_season_year()` to optionally send spans backwards (SciTools#5573) Added xarray phrasebook doc page (SciTools#5564) fixed spacing (SciTools#5572) DOCS: Removed broken git links. (SciTools#5569) More sensible time axis and tick labels for 2D plots (SciTools#5561) removed now incorrect statement. (SciTools#5555) [pre-commit.ci] pre-commit autoupdate (SciTools#5558) Exempt major release label from stalebot (SciTools#5559) updated link (SciTools#5556) Added whatsnew. (SciTools#5552) moved latest warning banner logic to conf.py (SciTools#5508) updated layout of top navbar (SciTools#5505) Oblique and Rotated Mercator (SciTools#5548) [pre-commit.ci] pre-commit autoupdate (SciTools#5549) [pre-commit.ci] pre-commit autoupdate (SciTools#5527) Bump scitools/workflows from 2023.09.1 to 2023.10.0 (SciTools#5540) nep29 drop table schedule numpy>1.21 (SciTools#5525) ...

docs/src/whatsnew/latest.rst

* upstream/main: Mergeback of `FEATURE_chunk_control` branch (SciTools#5588) [CI Bot] environment lockfiles auto-update (SciTools#5547) Mergeback of "Feature _split_attrs" branch (SciTools#5152) add whatsnew (SciTools#5596) Refactor area weighted regridding, improve performance (SciTools#5543) Allowing exemption to axis guessing on coords (SciTools#5551)

* main: DOCS: Numpydocs1 (SciTools#5578) add links to scitools-classroom repo. (SciTools#5609) Feedstock rc branch management in do-nothing script (SciTools#5515) Relocated the Technical Papers documentation to Further Topics. (SciTools#5602) Fix pp save of realization coordinate (SciTools#5568) Bump actions/checkout from 3 to 4 (SciTools#5460) Bump actions/github-script from 6 to 7 (SciTools#5580) Bump conda-incubator/setup-miniconda from 2 to 3 (SciTools#5607) CI: specify matplotlib-base (SciTools#5606) Mergeback of `FEATURE_chunk_control` branch (SciTools#5588) [CI Bot] environment lockfiles auto-update (SciTools#5547) Mergeback of "Feature _split_attrs" branch (SciTools#5152) add whatsnew (SciTools#5596) Refactor area weighted regridding, improve performance (SciTools#5543) Allowing exemption to axis guessing on coords (SciTools#5551)

HGWright and others added 2 commits October 25, 2023 13:30

allowing excemption to axis guessing on coords

6b49b10

[pre-commit.ci] auto fixes from pre-commit.com hooks

093372c

for more information, see https://pre-commit.ci

trexfeathers reviewed Oct 25, 2023

View reviewed changes

lib/iris/coords.py Outdated Show resolved Hide resolved

trexfeathers reviewed Oct 25, 2023

View reviewed changes

lib/iris/util.py Outdated Show resolved Hide resolved

HGWright and others added 3 commits November 7, 2023 14:59

updating pr

eafa1d0

merge commit

d42a2b7

[pre-commit.ci] auto fixes from pre-commit.com hooks

e942b32

for more information, see https://pre-commit.ci

bjlittle self-assigned this Nov 8, 2023

bjlittle self-requested a review November 8, 2023 14:16

bjlittle changed the title ~~Allowing excemption to axis guessing on coords~~ Allowing exemption to axis guessing on coords Nov 8, 2023

HGWright and others added 5 commits November 9, 2023 12:38

remove from metadata

875f827

merge conflict

056defa

[pre-commit.ci] auto fixes from pre-commit.com hooks

8cd64b2

for more information, see https://pre-commit.ci

remove merge clash

047f58b

Merge branch 'guess_coord' of github.com:HGWright/iris into guess_coord

247feb1

* 'guess_coord' of github.com:HGWright/iris: [pre-commit.ci] auto fixes from pre-commit.com hooks precommit

bjlittle requested changes Nov 9, 2023

View reviewed changes

lib/iris/coords.py Outdated Show resolved Hide resolved

lib/iris/coords.py Outdated Show resolved Hide resolved

lib/iris/coords.py Outdated Show resolved Hide resolved

lib/iris/util.py Outdated Show resolved Hide resolved

adding review comments

724d05f

bjlittle reviewed Nov 9, 2023

View reviewed changes

lib/iris/coords.py Outdated Show resolved Hide resolved

HGWright and others added 2 commits November 9, 2023 14:15

more review changes

3d183f5

[pre-commit.ci] auto fixes from pre-commit.com hooks

c901c12

for more information, see https://pre-commit.ci

HGWright and others added 5 commits November 9, 2023 15:34

parametrise and add tests

a121ec4

precommit changes

a7e6aa9

[pre-commit.ci] auto fixes from pre-commit.com hooks

b5da396

for more information, see https://pre-commit.ci

fix last test

6020a63

Merge branch 'guess_coord' of github.com:HGWright/iris into guess_coord

cffa5b6

* 'guess_coord' of github.com:HGWright/iris: [pre-commit.ci] auto fixes from pre-commit.com hooks precommit merge

HGWright marked this pull request as ready for review November 10, 2023 10:04

bjlittle requested changes Nov 17, 2023

View reviewed changes

HGWright and others added 5 commits November 17, 2023 11:45

addressing review comments

a9a45d1

[pre-commit.ci] auto fixes from pre-commit.com hooks

4151a7a

for more information, see https://pre-commit.ci

fix test failure

c35c3d1

Merge branch 'guess_coord' of github.com:HGWright/iris into guess_coord

3e6fba8

* 'guess_coord' of github.com:HGWright/iris: [pre-commit.ci] auto fixes from pre-commit.com hooks add precommit changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

d643915

for more information, see https://pre-commit.ci

HGWright mentioned this pull request Nov 17, 2023

Document the new ignore_axis functionality. #5589

Closed

HGWright and others added 8 commits November 17, 2023 14:40

add whatsnew and conftest files

5033391

fix merge conflict

faf4188

fix sentence

ed4c4c2

Merge branch 'main' into guess_coord

0180f58

[pre-commit.ci] auto fixes from pre-commit.com hooks

cfbe34f

for more information, see https://pre-commit.ci

fix flake8

6af7f81

fix last test

19dd66e

bjlittle reviewed Nov 17, 2023

View reviewed changes

docs/src/whatsnew/latest.rst Show resolved Hide resolved

bjlittle reviewed Nov 17, 2023

View reviewed changes

docs/src/whatsnew/latest.rst Outdated Show resolved Hide resolved

update whatsnew

b01f3f8

bjlittle approved these changes Nov 17, 2023

View reviewed changes

bjlittle merged commit 7770518 into SciTools:main Nov 17, 2023
17 checks passed

pp-mo mentioned this pull request Nov 21, 2023

Technical overview of netcdf interface #5598

Open

trexfeathers mentioned this pull request Feb 14, 2024

Document Coord.ignore_axis #5744

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allowing exemption to axis guessing on coords #5551

Allowing exemption to axis guessing on coords #5551

HGWright commented Oct 25, 2023

bjlittle left a comment •

edited

Loading

codecov bot commented Nov 9, 2023 •

edited

Loading

bjlittle left a comment

bjlittle commented Nov 17, 2023 •

edited

Loading

bjlittle commented Nov 17, 2023

Allowing exemption to axis guessing on coords #5551

Allowing exemption to axis guessing on coords #5551

Conversation

HGWright commented Oct 25, 2023

🚀 Pull Request

Description

bjlittle left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Nov 9, 2023 • edited Loading

Codecov Report

bjlittle left a comment

Choose a reason for hiding this comment

bjlittle commented Nov 17, 2023 • edited Loading

bjlittle commented Nov 17, 2023

bjlittle left a comment •

edited

Loading

codecov bot commented Nov 9, 2023 •

edited

Loading

bjlittle commented Nov 17, 2023 •

edited

Loading