201911_cel_base_20200424 #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
master. Needed as Compilation was failing.
* Create a SONiC configuration management service * Perform config db migration after loading config_db.json to redis DB * Migrate config-setup post migration hooks on image upgrade config-setup post migration hooks help user to migrate configurations from old image to new image. If the installed hooks are user defined they will not be part of the newly installed image. So these hooks have to be migrated to new image and only then they can be executing when the new image is booting. The changes in this fix migrate config-setup post-migration hooks and ensure that any hooks with the same filename in newly installed image are not overwritten. It is expected that users install new hooks as per their requirement and not edit existing hooks. Any changes to existing hooks need to be done as part of new image and not post bootup.
DHCP relay MONitor (dhcpmon) keeps track of DORA messages. If DHCP Relay is detected to be not forwarding DORA message, dhcpmon will log such event to syslog. Under the hood dhcpmon keeps counts of clients DR messages, forwarded DR messages, DHCP server OA messages, and forwarded OA messages. dhcpmon will check every 12 sec (configurable) if counts are monotonically increasing and record snapshot of those counters. dhcpmon will report discrepancies when detected between current counters and snapshot counters. pull-request: #3886 signed-off-by: Tamer Ahmed <[email protected]>
…status running in various SONiC containers. (#3940) * Add a monit config file for teamd container. Signed-off-by: Yong Zhao <[email protected]> * Add a copy mechanism to put the monit config file in teamd container into base image. Signed-off-by: Yong Zhao <[email protected]> * Add a monit config file for snmp container. Signed-off-by: Yong Zhao <[email protected]> * Add a copy mechanism to put the monit config file of snmp container into the base image. Signed-off-by: Yong Zhao <[email protected]> * Add a monit config file for dhcp_relay container in the dir base_image_files. Signed-off-by: Yong Zhao <[email protected]> * Add a copy mechanism to put the monit config file of dhcp_relay container into base image under /etc/monit/conf.d. Signed-off-by: Yong Zhao <[email protected]> * Add a monit config file for router advertiser container. Signed-off-by: Yong Zhao <[email protected]> * Add a copy mechanism to put the monit config file of router advertiser contianer into base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-Pmon] Add a monit config file for pmon container. Signed-off-by: Yong Zhao <[email protected]> * [Docker-Pmon] Add a copy mechanism to put the monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-lldp] Add a monit config file for lldp container. Signed-off-by: Yong Zhao <[email protected]> * [Docker-lldp] Add a copy mechanism to put the monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-bgp] Add a monit config file for BGP container. Signed-off-by: Yong Zhao <[email protected]> * [Docker-bgp] Add a copy mechanism to put monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-swss] Add a monit config file for the swss container. Signed-off-by: Yong Zhao <[email protected]> * [Docker-swss] Add a copy mechanism to put monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a monit config file for syncd container on barefoot platform. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a copy mechanism to put the monit config file into the base image on barefoot. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a monit config file for syncd container on broadcom. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a copy mechanism to put the monit config file into the base image on broadcom. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a monit config file for syncd container on cavium. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a copy mechanism to put the monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-centec] Add a monit config file for syncd container on centen platform. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a copy mechanism to put the monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a monit config file for syncd container on centen platform. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a copy mechanism to put the monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a monit config file for syncd container on marvell. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a copy mechanism to put the monit conifg file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a monit config file for syncd container on marvell-arm64. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a copy mechanism to put the monit config file into the base image on marvell-arm64. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a monit config file for syncd container on marvell-armhf. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a copy mechanism to put the monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a monit config file for syncd container on mellanox. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a copy mechanism to put the monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a monit config file for syncd container on nephos. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Add a copy mechanism to put the monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-sflow] Add a monit config file for sflow container. Signed-off-by: Yong Zhao <[email protected]> * [Docker-sflow] Add a copy mechanism to put the monit conifg file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-telemetry] Add a monit config file for telemetry container. Signed-off-by: Yong Zhao <[email protected]> * [Docker-telemetry] Add a copy mechanism to put the monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-database] Add a monit config file for database container. Signed-off-by: Yong Zhao <[email protected]> * [Docker-database] Add a copy mechanism to put the monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-Dhcprelay] Change a typo. Signed-off-by: Yong Zhao <[email protected]> * [Docker-Dhcprelay] Change the process name in monit config file to dhcrelay. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] There is no desserve process in syncd container on barefoot. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] There is no process desserve in syncd container on cavium. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] There is no process named desserve in syncd on centec. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] There is no process named desserve in syncd on marvell. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Should not delete the process desserve in syncd container on marvell. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Delete the process dsserve in syncd on marvell. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Delete the process dsserve in syncd container on marvell-arm64. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Delete the process dsserve in syncd container on marvell-armhf. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Delete the process dsserve in syncd container on mellanox. Signed-off-by: Yong Zhao <[email protected]> * [Docker-Radv] Change the process name to radvd. Signed-off-by: Yong Zhao <[email protected]> * [Docker-telemetry] Correct a typo in monit_telemetry. Signed-off-by: Yong Zhao <[email protected]> * [Docker-teamd] Delete the monit config file for teamd. Signed-off-by: Yong Zhao <[email protected]> * [Docker-teamd] Delete the mechanism to copy the monit config file into base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-dhcprelay] Delete the monit config file for dhcp_relay container. Signed-off-by: Yong Zhao <[email protected]> * [Docker-dhcprelay] Delete the mechanism to copy the monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-radv] Delete the monit config file foe radv container. Signed-off-by: Yong Zhao <[email protected]> * [Docker-radv] Delete the mechanism to copy the monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-bgp] change the monit config file for BGP container such that monit only generates alert if the process is not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-snmp] Change the monit config file for snmp container such that monit only generates alret if the process is not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-pmon] Change the monit config file for pmon container such that monit only generates alert if the processes are not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-lldp] Change the monit config file for lldp container such that monit only generates alerts if some processes are not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-pmon] Delete the monit config file for pmon container since some of processes are not running depended on the type of box. Signed-off-by: Yong Zhao <[email protected]> * [Docker-pmon] Delete the copy mechanism to copy the monit config file into the base image. Signed-off-by: Yong Zhao <[email protected]> * [Docker-lldp] Change the matching name for the process lldpd. Signed-off-by: Yong Zhao <[email protected]> * [Docker-swss] Change the monit config file for swss container such that monit only generates alerts if the processes are not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Change the monit config file for syncd container on barefoot such that monit only generates alerts if the process is not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Correct a typo in monit config file. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Change the monit config file for syncd container on broadcom such that monit only generates alerts if the processes are not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Change the monit config file for syncd container on cavium such that monit only generates alerts if the process is not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Change the monit config file for syncd container such that monit only generates alerts if the process is not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Change the monit config file for syncd container on marvell such that monit only generates alerts if the process is not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Change the monit config file for syncd container on marvell-arm64 such that monit only generates alerts if the process is not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Change the monit config file for syncd container on marvell-armhf such that monit will generate alert if the process is not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Change the monit config file for syncd container on mellanox such that monit only generates alerts if the process is not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-sycnd] Change the monit config file for syncd container such that monit only generates alerts if the processes are not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-sflow] Change the monit config file for sflow container such that monit only generates alerts if the process is not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-telemetry] Change the monit config file for telemetry container such that monit only generates alerts if the processes are not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-database] Change the monit config file for database container such that monit only generates alerts if the process is not running for 5 minutes. Signed-off-by: Yong Zhao <[email protected]> * [Docker-database] Use 4 spaces to replace 2 spaces in monit config file. Signed-off-by: Yong Zhao <[email protected]> * [Docker-bgp] Use 4 spcess to replace 2 spaces in monit config file. Signed-off-by: Yong Zhao <[email protected]> * [Docker-lldp] Use 4 spaces to replace 2 spaces in monit config file. Signed-off-by: Yong Zhao <[email protected]> * [Docker-swss] Use 4 spaces to replace 2 space in monit config file. Signed-off-by: Yong Zhao <[email protected]> * [Docker-sflow] Use 4 spaces to replace 2 spaces in monit config file. Signed-off-by: Yong Zhao <[email protected]> * [Docker-snmp] Use 4 spaces to replace 2 spaces in monit config file. Signed-off-by: Yong Zhao <[email protected]> * [Docker-telemetry] Use 4 spaces to replace 2 spaces in monit config file. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Use 4 spaces to replace 2 spaces in the monit config file on barefoot. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Use 4 spaces to replace 2 spaces in the monit config file on broadcom. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Use 4 spaces to replace 2 spaces in the monit config file on cavium. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Use 4 spaces to replace 2 spaces in the monit config file on centec. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Use 4 spaces to replace 2 spaces in the monit config file on marvell. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Use 4 spaces to replace 2 spaces in the monit config file on mellanox. Signed-off-by: Yong Zhao <[email protected]> * [Docker-syncd] Use 4 spaces to repalce 2 spaces in the monit config file on nephos. Signed-off-by: Yong Zhao <[email protected]> * [Docker-bgp] Remove the trailing extra spaces in monit config file. Signed-off-by: Yong Zhao <[email protected]>
… files (#3973) This is an addendum to #3958, which also instructs apt to ignore the "Valid Until" date in Release files inside the slave containers, making a complete solution, much like the previously abandoned PR #2609. This patch also unifies file names and contents. When the Debian team archives a repo, it stops updating the "Valid Until" date, thus apt-get will not apply updates for that repo unless we explicitly tell it to ignore the "Valid Until" date. Also, this has become an issue with active (i.e., non-archived) repos twice in the past year because the Debian folks seem to occasionally let the expiration lapse before updating the date. This will cause SONiC builds to fail with a message like E: Release file for http://debian-archive.trafficmanager.net/debian-security/dists/jessie/updates/InRelease is expired (invalid since 3d 3h 11min 20s). Updates for this repository will not be applied. until the dates have been updated and propagated to all mirrors. With this patch, SONiC should no longer be affected by lapsed "Valid Until" dates, whether they be accidental or purposeful.
…3974) * [Monit] Change the monitoring period of monit from 120 seconds to 60 seconds and also at the same time double the interval for existing sonic monit config file in host. Signed-off-by: Yong Zhao <[email protected]>
…ection is stable (#4003)
Provide build option for RESTAPI docker
* Fix bgpcfgd error. Previously subscribers were notified before all dependencies were ready
Signed-off-by: Nazarii Hnydyn <[email protected]>
743, 754, 773, 784
Update rules for frr package. Update frr submodule
Updating the startsecs=5sec for teamsyncd to make the time for which the process needs to stay up before declaring the startup successfull.
* Changes in sonic-buildimage for the NAT feature - Docker for NAT - installing the required tools iptables and conntrack for nat Signed-off-by: [email protected] * Add redis-tools dependencies in the docker nat compilation * Addressed review comments * add natsyncd to warm-boot finalizer list * addressed review comments * using swsscommon.DBConnector instead of swsssdk.SonicV2Connector * Enable NAT application in docker-sonic-vs
- move single instance services into their own folder - generate Systemd templates for any multi-instance service files in slave.mk - detect single or multi-instance platform in systemd-sonic-generator based on asic.conf platform specific file. - update container hostname after creation instead of during creation (docker_image_ctl) - run Docker containers in a network namespace if specified - add a service to create a simulated multi-ASIC topology on the virtual switch platform Signed-off-by: Lawrence Lee <[email protected]> Signed-off-by: Suvarna Meenakshi <[email protected]>
…se new DBConnector (#3923) * [MultiDB] (./dockers dirs): replace redis-cli with sonic-db-cli and use new DBConnector * remove unnecessary quota * update typo
* SAI implementation 1.15.5 (headers 1.5.1) * SDK 4.3.2908 * FW xx.2000.2720 Signed-off-by: Volodymyr Samotiy <[email protected]>
…e. (#4033) Since the syncd process running on different platforms will have the different full path names, we change the full path name of process syncd in the monit config file such that it will be universal and is not for a specific vendor. Signed-off-by: Yong Zhao <[email protected]>
…onic-db-cli and use new DBConnector (#4035) * [MultiDB] (except ./src and ./dockers dirs): replace redis-cli with sonic-db-cli and use new DBConnector * update comment for a potential bug * update comment * add TODO maker as review reqirement
Fixed SAI_BUFFER_PROFILE_ATTR_BUFFER_SIZE to uint64_t
* [mellanox]: Add SSD FW update tool. Signed-off-by: Nazarii Hnydyn <[email protected]> * [mellanox]: Align Platform API. Signed-off-by: Nazarii Hnydyn <[email protected]> * [mellanox]: Fix firmware description. Signed-off-by: Nazarii Hnydyn <[email protected]> * [mellanox]: Update SSD tool. Signed-off-by: Nazarii Hnydyn <[email protected]>
…ack when no ACL_RULE/INTERFACE is present. (#4226) * Fix bugs - "show run acl/interfaces" returns traceback when no ACL_RULE/INTERFACE is present in configuration - Change logic in main to take data only if the var_json appears in DB. - Add unit testing for bug fix & fix comments Signed-off-by: Noa Or <[email protected]>
Changes made to support multi-asic platform. Added multi-instance support for swss, syncd, database, bgp, teamd and lldp.
Signed-off-by: Nazarii Hnydyn <[email protected]>
… they were set initially (#4375) sonic-netns-exec fails to execute below command in swss.sh: sonic-netns-exec "$NET_NS" sonic-db-cli $1 EVAL " local tables = {$2} for i = 1, table.getn(tables) do local matches = redis.call('KEYS', tables[i]) for j,name in ipairs(matches) do redis.call('DEL', name) end end" 0 This command fails with error " redis.exceptions.ResponseError: value is not an integer or out of range" . Root cause: When sonic-netns-exec executes the above function, argument passed to sonic-db-cli is NOT executed as a single script. The argument is passed as separate keywords to sonic-db-cli, as below: ['EVAL', 'local', 'tables', '=', "{'PORT_TABLE*'}", 'for', 'i', '=', '1,', 'table.getn(tables)', 'do', 'local', 'matches', '=', "redis.call('KEYS',", 'tables[i])', 'for', 'j,name', 'in', 'ipairs(matches)', 'do', "redis.call('DEL',", 'name)', 'end', 'end', '0'] - How I did it To make sure that the parameters are passed as they were set initially, fix sonic-netns-exec to use double quoted "$@", where "$@" is "$1" "$2" "$3" ... "${N}" After fix, the argument passed to sonic-db-cli is as below: Argument passed to sonic-db-cli: ['EVAL', "\n local tables = {'PORT_TABLE*'}\n for i = 1, table.getn(tables) do\n local matches = redis.call('KEYS', tables[i])\n for j,name in ipairs(matches) do\n redis.call('DEL', name)\n end\n end", '0'] Signed-off-by: SuvarnaMeenakshi <[email protected]>
- enabling http/https endpoint and mounting the certificates directory - updating the sonic-restapi submodule
…4432) Install kubeadm, which transparently installs kubelet & kubectl As well download required Kubernetes images required to run as kubernetes node. The kubelet service is intentionally kept in disabled state, as it would otherwise continuously restart wasting resources, until join to master.
from 3.7.3.3-3 to 3.7.3.3-4 Fixes for PFC WD Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
[DBConnector] Add methods to set/get Redis client name (#335)
* [DellEMC] s5232f console and sfputil fix Remove hardcoding 115K baudrate for console Enhance sfputil api as per spec
mudsut4ke
pushed a commit
that referenced
this pull request
Mar 16, 2021
30d09be fix the muxcable state change notification received from other modules, omit the check inside hw_state table (#159) 32ec23c [xcvrd] Fix crash on platforms which support media settings with Python 3 (#158) 47bcf90 [xcvrd] Save the dom_capability of transceiver into db (#72) b9381a5 [xcvrd] Fix xcvrd crash on other port prefixes (#123) c3c1a59 [xcvrd] Make functions used for media setting python3 compatible (#153) e179ffc [psud] Refactor unit tests; increase unit test coverage (#146) Signed-off-by: vaibhav-dahiya <[email protected]>
mudsut4ke
pushed a commit
that referenced
this pull request
Mar 16, 2021
* src/sonic-platform-daemons 068bccc...e5165b7 (7): > [xcvrd] Fix crash: If 'dom_capability' not in port_info_dict, insert 'N/A' (#162) > fix the muxcable state change notification received from other modules, omit the check inside hw_state table (#159) > [xcvrd] Fix crash on platforms which support media settings with Python 3 (#158) > [xcvrd] Save the dom_capability of transceiver into db (#72) > [xcvrd] Fix xcvrd crash on other port prefixes (#123) > [xcvrd] Make functions used for media setting python3 compatible (#153) > [psud] Refactor unit tests; increase unit test coverage (#146)
jerseyang
pushed a commit
that referenced
this pull request
Jun 4, 2021
30d09be fix the muxcable state change notification received from other modules, omit the check inside hw_state table (#159) 32ec23c [xcvrd] Fix crash on platforms which support media settings with Python 3 (#158) 47bcf90 [xcvrd] Save the dom_capability of transceiver into db (#72) b9381a5 [xcvrd] Fix xcvrd crash on other port prefixes (#123) c3c1a59 [xcvrd] Make functions used for media setting python3 compatible (#153) e179ffc [psud] Refactor unit tests; increase unit test coverage (#146) Signed-off-by: vaibhav-dahiya <[email protected]>
jerseyang
pushed a commit
that referenced
this pull request
Jun 4, 2021
* src/sonic-platform-daemons 068bccc...e5165b7 (7): > [xcvrd] Fix crash: If 'dom_capability' not in port_info_dict, insert 'N/A' (#162) > fix the muxcable state change notification received from other modules, omit the check inside hw_state table (#159) > [xcvrd] Fix crash on platforms which support media settings with Python 3 (#158) > [xcvrd] Save the dom_capability of transceiver into db (#72) > [xcvrd] Fix xcvrd crash on other port prefixes (#123) > [xcvrd] Make functions used for media setting python3 compatible (#153) > [psud] Refactor unit tests; increase unit test coverage (#146)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)