Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to build restapi docker #3993

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Changes to build restapi docker #3993

merged 3 commits into from
Jan 10, 2020

Conversation

sumukhatv
Copy link
Contributor

- What I did
Make changes to build sonic-restapi docker
https://github.com/Azure/sonic-restapi
- How I did it
Add Dockerfiles
Create submodule sonic-restapi to pull code from sonic-restapi repo
- How to verify it
should see target/docker-sonic-restapi.gz once built
- Description for the changelog

Added supporting files and changes to build sonic-restapi docker

- A picture of a cute animal (not mandatory but encouraged)

@sumukhatv sumukhatv requested a review from lguohan January 8, 2020 20:00
@lguohan
Copy link
Collaborator

lguohan commented Jan 9, 2020

build failure due to permission issue. can you investigate?

https://sonic-jenkins.westus2.cloudapp.azure.com/job/broadcom/job/buildimage-brcm-all-pr/1960/consoleFull

@sumukhatv
Copy link
Contributor Author

Retest broadcom please

1 similar comment
@sumukhatv
Copy link
Contributor Author

Retest broadcom please

@lguohan
Copy link
Collaborator

lguohan commented Jan 10, 2020

in another PR, you need to add critical process like this one. https://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-orchagent/critical_processes

@sumukhatv sumukhatv merged commit 3b1ee5d into sonic-net:master Jan 10, 2020
abdosi pushed a commit that referenced this pull request Jan 21, 2020
prsunny pushed a commit that referenced this pull request Feb 5, 2020
pphuchar pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Mar 9, 2020
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants