-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mellanox]: Enable CPLD update progress bar #4363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please add more details to the PR desription according to the listed below:
|
stephenxs
previously approved these changes
Apr 8, 2020
nazariig
force-pushed
the
master-cpld-progress-bar
branch
from
April 9, 2020 12:12
d364a66
to
314ff6b
Compare
This pull request introduces 1 alert when merging 314ff6bfef4ca3bc186ab032d6176142f1a5f9bd into 7405f8c - view on LGTM.com new alerts:
|
liat-grozovik
previously approved these changes
Apr 10, 2020
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
nazariig
force-pushed
the
master-cpld-progress-bar
branch
from
April 10, 2020 09:34
314ff6b
to
c96c90b
Compare
volodymyrsamotiy
approved these changes
Apr 13, 2020
@jleveque if no concerns - please help to merge |
jleveque
approved these changes
Apr 14, 2020
abdosi
pushed a commit
that referenced
this pull request
Apr 15, 2020
Signed-off-by: Nazarii Hnydyn <[email protected]>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
Signed-off-by: Nazarii Hnydyn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn [email protected]
Summary:
cpldupdate
invocation: make output realtime- What I did
- How I did it
cpldupdate
progress bar with--print-progress
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)