Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get random socket address #47

Open
wants to merge 30 commits into
base: osx_support
Choose a base branch
from

Conversation

y-luis-rojo
Copy link
Contributor

@y-luis-rojo y-luis-rojo commented Oct 12, 2018

I tried to run tests in MacOS using osx_support branch (after merging master into it) and came out that test_stack:test_sync_run and test_stcak:test_async_run were failing because sipp command for UAC was triggered with 0.0.0.0 as server IP, so, I change to 127.0.0.1 when retrieving a random socket address with host=None.

I am not sure whether is related to MacOS but it did not fail when testing in Ubuntu Trusty.

y-luis-rojo and others added 8 commits July 27, 2018 00:23
Update .travis.yml to include --full build flag
Fix sipp build. Test with default Trusty.
Fix sipp build. Test with default Trusty.
Added description in README.
Feature/support disabling screen_file argument
…rder

remote-host as last position argument
@y-luis-rojo
Copy link
Contributor Author

Related to #17

@y-luis-rojo y-luis-rojo changed the title Osx support Get random socket address Oct 12, 2018
@goodboy
Copy link
Member

goodboy commented Oct 13, 2018

I tried to run tests in MacOS using osx_support branch (after merging master into it)

@y-luis is it possible to try rebasing the history instead?
Try from the osx branch git rebase upstream/master (or whatever you called the source repo).

@goodboy
Copy link
Member

goodboy commented Jul 4, 2019

@y-luis just dropped pypy from CI in #52.
Can you rebase this onto master and see how we do?

Also I think we can actually run CI against mac with the travis MacOS env. This might be worth putting in the effort now?

@goodboy
Copy link
Member

goodboy commented Jul 4, 2019

Hmm looking at the CI results in detail it seems we've got bigger problems with this branch on linux for the py3 versions?

This seems odd. I wonder if moving to selectors will resolve some of this?

@goodboy goodboy mentioned this pull request Jul 4, 2019
Tyler Goodlet and others added 5 commits July 4, 2019 15:22
Add a test which demonstrates a bug where if a scenario is loaded from
a directory that the `proxyaddr` is never set.
Thanks to @y-luis for originally finding and fixing this problem.
The original PR (SIPp#35) was discarded accidentally.
@y-luis-rojo
Copy link
Contributor Author

Rebased from master. I have not had a lot of time to check it. Hope I can later.

@goodboy
Copy link
Member

goodboy commented Jul 5, 2019

@y-luis thanks. I think we might have to delay this until we get py3 only support in because I don't want to have to fight with select stuff on py3 that's already been fixed/handled in the stdlib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants