Fix sipp build. Test with default Trusty. #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heh, definitely not. Iirc I originally used it to get tests working in the first place due to some library restriction @y-luis this looks great! Thanks so much for putting in this work! |
goodboy
approved these changes
Aug 20, 2018
|
@vodik you mind taking a quick peek at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tgoodlet, I tried to find why tests were failing. I tried installing SIPp following docs instructions, and tests with Python 2 were successful. When researching why Python 3.5 did not work, I found a Travis blog entry about ending support for Precise, so I switch to Trusty (default) and tests ran well. Is Precise a requirement for you? If so, we could research more about it, but if it is not, I propose to change to Trusty.