Update __init__.py #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `dirpath` and `proxyaddr` are set, the last is ignored because of its indentation.
Closed
goodboy
requested changes
Jul 26, 2018
|
@y-luis rebase this onto master and add a test if you don't mind. |
|
@y-luis wait this was never merged? |
|
@tgoodlet, no, it was never merged, I think you are right, it may be related with #39, but I did not had the opportunity to test it. I realized I renamed the fork, and now this PR shows |
|
@y-luis I wrote a test last night and added your fix (since we need both). Surprisingly, at least for me, it doesn't solve #39... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
dirpathandproxyaddrare set, the last is ignored because of its indentation.