Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .travis.yml #37

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Update .travis.yml #37

merged 1 commit into from
Jul 27, 2018

Conversation

y-luis-rojo
Copy link
Contributor

@y-luis-rojo y-luis-rojo commented Jul 26, 2018 •
edited
Loading

build.sh script missing arguments.

@vodik vodik requested a review from goodboy July 27, 2018 06:16
@vodik
Copy link
Member

vodik commented Jul 27, 2018

@tgoodlet understand the issue at a glance? I know its been a while.

@goodboy
Copy link
Member

goodboy commented Jul 27, 2018

@vodik yeah, no idea. Gonna rebuild sipp locally and rerun now.

@goodboy
Copy link
Member

goodboy commented Jul 27, 2018

Huh, yeah runs fine for me. Gonna respin it.

@goodboy
Copy link
Member

goodboy commented Jul 27, 2018

I mean either way if sipp now needs the --full flag we must have this in.
If there's a CI false negative we can deal with that separately.

@y-luis-rojo
Copy link
Contributor Author

@tgoodlet I am not sure whether you need the --full flag, maybe it only needs specific --with-* or --none at all.

@goodboy
Copy link
Member

goodboy commented Jul 27, 2018

Yeah might have something to do with updates (introducing races) to sipp itself?
We can maybe pin to the latest release tag?

@goodboy
Copy link
Member

goodboy commented Jul 27, 2018 •
edited
Loading

@y-luis yeah the CI build from your other PR requires a flag. I don't see why we wouldn't use --full as it should include the most coverage of sipp itself. For me this is good to go. The test failure is another issue likely related to recent changes to sipp core.

@goodboy goodboy merged commit fd5715f into SIPp:master Jul 27, 2018
@y-luis-rojo y-luis-rojo deleted the patch-2 branch July 27, 2018 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodboy goodboy goodboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y-luis-rojo @vodik @goodboy