Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular 19 #19772

Open
wants to merge 17 commits into
base: develop-next-major
Choose a base branch
from
Open

Conversation

pawelfras
Copy link
Contributor

@pawelfras pawelfras commented Dec 12, 2024

QA

  • migration from SPA 6.x with SSR (Angular 15)
  • migration from SPA 2211.19 (Angular 17)
  • migration from SPA 2211.18 with SSR (Angular 17)
  • installation of SPA in fresh Angular 19 app
  • installation of SPA with SSR in fresh Angular 19 app
  • CCv2 deployment

@pawelfras pawelfras requested review from a team as code owners December 12, 2024 10:13
@github-actions github-actions bot marked this pull request as draft December 12, 2024 10:13
- ran `npx nx migrate latest` (bump most of libraries to the latest version) and `npx nx migrate --run-migration` (run packages' migration, all except angular's migration from initializer tokens to helper functions)
- bump '@angular/animations' to version '^19.0.3'
- bump '@angular/common' to version '^19.0.3'
- bump '@angular/compiler' to version '^19.0.3'
- bump '@angular/core' to version '^19.0.3'
- bump '@angular/forms' to version '^19.0.3'
- bump '@angular/platform-browser' to version '^19.0.3'
- bump '@angular/platform-browser-dynamic' to version '^19.0.3'
- bump '@angular/platform-server' to version '^19.0.3'
- bump '@angular/pwa' to version '^19.0.4'
- bump '@angular/router' to version '^19.0.3'
- bump '@angular/service-worker' to version '^19.0.3'
- bump '@angular/ssr' to version '^19.0.4'
- bump '@ng-select/ng-select' to version '^14.1.0'
- bump 'angular-oauth2-oidc' to version '19.0.0'
- bump 'ngx-infinite-scroll' to version '^19.0.0'
- bump 'zone.js' to version '0.15.0'
- bump '@angular-devkit/build-angular' to version '^19.0.4'
- bump '@angular-devkit/core' to version '^19.0.4'
- bump '@angular-devkit/schematics' to version '^19.0.4'
- bump '@angular-eslint/builder' to version '19.0.2'
- bump '@angular-eslint/eslint-plugin' to version '^19.0.2'
- bump '@angular-eslint/eslint-plugin-template' to version '^19.0.2'
- bump '@angular-eslint/schematics' to version '^19.0.2'
- bump '@angular-eslint/template-parser' to version '^19.0.2'
- bump '@angular-eslint/test-utils' to version '^19.0.2'
- bump '@angular-eslint/utils' to version '^19.0.2'
- bump '@angular/cli' to version '^19.0.4'
- bump '@angular/compiler-cli' to version '^19.0.3'
- bump '@angular/language-service' to version '^19.0.3'
- bump '@nx/angular' to version '^20.2.2'
- bump '@nx/devkit' to version '^20.2.2'
- bump '@nx/eslint-plugin' to version '^20.2.2'
- bump '@nx/jest' to version '^20.2.2'
- bump '@nx/workspace' to version '^20.2.2'
- bump '@schematics/angular' to version '^19.0.4'
- bump 'jest-preset-angular' to version '14.4.2'
- bump 'ng-packagr' to version '^19.0.1'
- bump 'nx' to version '^20.2.2'
- bump 'typescript' to version '^5.6.3'
- add `standalone: false` to all components, directives and pipes
  for more, see: angular/angular#57643
- add rule `"@angular-eslint/prefer-standalone": "off"` in eslint files
- remove deprecated `"angular-eslint/no-host-metadata-property"`
  for more, see: angular-eslint/angular-eslint#2113
- update '@angular/ssr' import paths to use the new '/node' entry point when 'CommonEngine' is detected
  for more, see: angular/angular-cli#28278
- change range specifier for typescript library to meet Angular's requirement (>=5.5.0 and <5.7.0)
- fix building libs and CSR by solvig type errors provided with TS 5.6
- this update is required for SSR to work, because previous version use Angualr 18 API which is no longer part of @angular/core in v19.
  for more, see: angular/angular#58891
- fix type issues
- use `takeUntil` with destroy subject in `trending-searches.service.ts` as a more reliable cleanup method to properly handle cleanup
- remove redundant 'declatartion: true' from 'tsconfig.schematics.json' files,
  that caused issues in unit tests due to type errors in '@schematics/angular' library
  'Buffer is not a generic type'. The issue appeared because '*.d.ts' files are taken into consideration when running tests, maybe unnecessary
  for more, see: https://github.com/angular/angular-cli/blob/4db4dd4315fd8c31872bbf1e82e3414eea15ffef/goldens/public-api/angular_devkit/schematics/index.api.md\?plain\=1\#L498
- update snapshots with new budget thresholds
  for more, see: angular/angular-cli#28255
- update snapshots with new packages versions
- update schematics and related tests with the new `server.ts` location
  for more, see: angular/angular-cli#28571
- adjust positions in utils tests to reflect the `standalone: false` in component decorators
- adjust SSR schematics to remove `withEventReplay()` that Angular installs by default
  for more, see:
- refactor tests for 2211.19 SSR migration to make them independent of Angular's schematics
  for more, see: angular/angular-cli#28469
- move `@angular-eslint/prefer-standalone` to global eslint rules
- add missing `OnDestroy` implementation in cds library
- remove `@angular-eslint/no-host-metadata-property` from the config as it is no longer part of the package
 for more, see: angular-eslint/angular-eslint#2113
- add missing comma to all files where 'standalone: false' was added
- upgrade to version that supports TS >= 5.6.3
- add `@typescript-eslint/rule-tester` which was missing peer dependency of `@angular-eslint/test-utils`
- adjust import-utils.ts to meet new typing
@pawelfras pawelfras marked this pull request as ready for review December 17, 2024 13:59
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

Copy link

cypress bot commented Dec 17, 2024

spartacus    Run #46431

Run Properties:  status check passed Passed #46431  •  git commit 631bef5a9a ℹ️: Merge a004277266f0a3a6ab86ce59ff04298784d43eca into a496d58e6498e52b49c926238145...
Project spartacus
Branch Review epic/upgrade-to-angular-19
Run status status check passed Passed #46431
Run duration 13m 24s
Commit git commit 631bef5a9a ℹ️: Merge a004277266f0a3a6ab86ce59ff04298784d43eca into a496d58e6498e52b49c926238145...
Committer Paweł Fraś
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 22
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 811
View all changes introduced in this branch ↗︎

- bump `@ngrx/*` libraries to `19.0.0`
- adjust failing unit tests to satisfy types
@pawelfras pawelfras marked this pull request as ready for review December 18, 2024 12:02
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

- update snapshots
- adjust ssr/engine tests to use new required `standalone: false`
- adjust jest config for `setup/ssr` unit tests to use `beasties` from node modules instead of the internalized one provided with `@angular/ssr` due to issues with not supported ES format
@github-actions github-actions bot marked this pull request as draft December 18, 2024 16:02
@pawelfras pawelfras marked this pull request as ready for review December 18, 2024 16:03
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft December 19, 2024 08:17
@pawelfras pawelfras marked this pull request as ready for review December 19, 2024 08:17
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft December 19, 2024 08:43
@pawelfras pawelfras marked this pull request as ready for review December 19, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant