refactor: replace critters with beasties
#28726
Conversation
alan-agius4
added
action: review
|
Note: the lint failure is for Had a chat with @devversion and confirmed that it’s okay to merge this in a red state. |
alan-agius4
force-pushed
the
replace-critters
branch
3 times, most recently
from
9188c69 to
0f22795
Compare
packages/angular/build/src/utils/index-file/inline-critical-css.ts
Outdated
Show resolved
Hide resolved
| "@bazel/runfiles": "^5.8.1", | ||
| "@discoveryjs/json-ext": "0.6.2", | ||
| "@inquirer/confirm": "5.0.0", | ||
| "@inquirer/prompts": "7.0.0", | ||
| "@listr2/prompt-adapter-inquirer": "2.0.17", | ||
| "@rollup/plugin-alias": "^5.1.1", |
There was a problem hiding this comment.
Question: Are these dependency changes expected? I'm surprised we didn't already have this for Critters?
There was a problem hiding this comment.
This is because of the second commit that switches the bundling from esbuild to use rollup.
The Critters project has been transferred to the Nuxt team, who will now manage its development and has been renamed to Beasties. See: https://github.com/danielroe/beasties
…itters/beasties Esbuild exhibits issues when handling code that is generated and then reprocessed by itself, creating challenges when using it to bundle libraries or library components. To remove these issues, we've replaced Esbuild with Rollup for bundling `beasties`. See: evanw/esbuild#3723
alan-agius4
force-pushed
the
replace-critters
branch
from
0f22795 to
44c4947
Compare
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The Critters project has been transferred to the Nuxt team, who will now manage its development and has been renamed to Beasties.
See: https://github.com/danielroe/beasties