-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@schematics/angular): update app-shell and ssr schematics to adopt new Server Rendering API #28571
feat(@schematics/angular): update app-shell and ssr schematics to adopt new Server Rendering API #28571
Conversation
32f3ff5
to
6aabfc0
Compare
6aabfc0
to
34d2ba2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I'm not super familiar with schematics. Maybe @clydin has more useful feedback to give here?
tests/legacy-cli/e2e/tests/server-rendering/express-engine-standalone.ts
Outdated
Show resolved
Hide resolved
34d2ba2
to
2c34351
Compare
6f15747
to
e30b9a6
Compare
e30b9a6
to
91b9704
Compare
179b846
to
8d6a561
Compare
…pt new Server Rendering API This commit revises the app-shell and ssr schematics to incorporate the new Server Rendering API, along with the integration of server-side routes. BREAKING CHANGE: The app-shell schematic is no longer compatible with Webpack-based builders.
8d6a561
to
5e8aeec
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit revises the app-shell and server schematics to incorporate the new Server Rendering API, along with the integration of server-side routes.
BREAKING CHANGE: The app-shell schematic is no longer compatible with Webpack-based builders.