Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@schematics/angular): increase new application anyComponentSyle budget thresholds #28255

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 21, 2024

The 2kB/4kB warning/error thresholds for any component style within an application has now been increased to 4kB/8kB for warnings/errors respectively. This allows for more complex styles within a component while also reducing the likelihood of the budget rule being disabled or removed. The new limits still provide diagnostics for extreme size cases such as accidentally importing all Bootstrap or Material styles into an individual component. Such instances are a primary use case for the budget.

…tyle budget thresholds

The 2kB/4kB warning/error thresholds for any component style within an application
has now been increased to 4kB/8kB for warnings/errors respectively. This allows for
more complex styles within a component while also reducing the likelihood of the budget
rule being disabled or removed. The new limits still provide diagnostics for extreme
size cases such as accidentally importing all Bootstrap or Material styles into an
individual component. Such instances are a primary use case for the budget.
@clydin clydin added the target: major This PR is targeted for the next major release label Aug 21, 2024
@clydin clydin requested a review from alan-agius4 August 21, 2024 18:04
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 21, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 21, 2024
@alan-agius4 alan-agius4 merged commit d223d1e into angular:main Aug 21, 2024
33 checks passed
@clydin clydin deleted the schematics/component-style-budget branch August 21, 2024 19:17
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants