Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt clone step to work with customer-managed Repos (BYOG) #4966

Merged
merged 38 commits into from
Jun 25, 2024
Merged

Adapt clone step to work with customer-managed Repos (BYOG) #4966

merged 38 commits into from
Jun 25, 2024

Conversation

doldsimo
Copy link
Member

Changes

  • Tests
  • Documentation

@doldsimo doldsimo requested a review from a team as a code owner June 19, 2024 14:20
@doldsimo doldsimo requested a review from DanielMieg June 20, 2024 13:47
@doldsimo doldsimo requested a review from DanielMieg June 21, 2024 11:40
@DanielMieg
Copy link
Member

/it

@DanielMieg DanielMieg enabled auto-merge (squash) June 25, 2024 08:05
@DanielMieg DanielMieg merged commit 65dbd45 into SAP:master Jun 25, 2024
12 of 13 checks passed
o-liver pushed a commit that referenced this pull request Jun 28, 2024
@doldsimo @DanielMieg @o-liver
Adapt clone step to work with customer-managed Repos (BYOG) (#4966)
837c6c7 
* adding byog credentials for clone command

* adding unit tests for clone body

* adding parameters

* adding optional byog parameters

* fixing typo in username

* remove aliases in config yaml

* change yaml config

* logs

* change info log

* change logs

* remove logs

* adding log statements

* remove log statements

* fixing typo in test class

* change repoTest structure

* remove comment

* remove comment

* generate

* adding unit test comments

* adding error handling

* adding isByog check

* fixing unit test

* generate

* Update manageGitRepositoryUtils_test.go

* restructure isByog parameter

* adding empty line for md linter

* adding config.yaml example to docs

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* adding release

---------

Co-authored-by: Daniel Mieg <[email protected]>
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into kaniko-context-pref…
e1ff1bb 
…ix-fix

* origin/master: (361 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@doldsimo @DanielMieg @maxatsap
Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
7f719ab 
* adding byog credentials for clone command

* adding unit tests for clone body

* adding parameters

* adding optional byog parameters

* fixing typo in username

* remove aliases in config yaml

* change yaml config

* logs

* change info log

* change logs

* remove logs

* adding log statements

* remove log statements

* fixing typo in test class

* change repoTest structure

* remove comment

* remove comment

* generate

* adding unit test comments

* adding error handling

* adding isByog check

* fixing unit test

* generate

* Update manageGitRepositoryUtils_test.go

* restructure isByog parameter

* adding empty line for md linter

* adding config.yaml example to docs

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* adding release

---------

Co-authored-by: Daniel Mieg <[email protected]>
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into malwarescan-async-scan
c3e0329 
* origin/master: (421 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into whitesource-sbt-con…
12b7a43 
…fig-fix

* origin/master: (460 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@maxatsap
Merge remote-tracking branch origin/whitesource-sbt-config-fix into v…
81aa48d 
…1.371.0-edp

* origin/whitesource-sbt-config-fix: (462 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Oct 1, 2024
@maxatsap
Merge remote-tracking branch 'origin/whitesource-sbt-config-fix' into…
ecd8d32 
… v1.386.0-edp

* origin/whitesource-sbt-config-fix: (462 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Nov 20, 2024
@maxatsap
Merge remote-tracking branch 'origin/whitesource-sbt-config-fix' into…
8d895dd 
… v1.406.0-edp

* origin/whitesource-sbt-config-fix: (463 commits)
  allow whitesource sbt args to be overridden
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jan 10, 2025
@maxatsap
Merge remote-tracking branch 'origin/whitesource-sbt-config-fix' into…
4767264 
… v1.418.0-edp

* origin/whitesource-sbt-config-fix: (463 commits)
  allow whitesource sbt args to be overridden
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielMieg DanielMieg DanielMieg approved these changes

Assignees
No one assigned
Labels
ABAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doldsimo @DanielMieg