Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving buildDescriptorExcludeList for npm #4976

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

vijayanjay
Copy link
Contributor

@vijayanjay vijayanjay commented Jun 26, 2024

Changes

Fixes:
In whitesourceExcuteScan piper step the buildDescriptorExcludeList parameter is not excluding the npm modules during scanning. To address this, we have implemented the ignoreDirectoryPatterns functionality specifically for NPM modules to exclude the specified modules during the scan.

  • Tests
  • Documentation

@vijayanjay vijayanjay self-assigned this Jun 26, 2024
@vijayanjay vijayanjay requested a review from a team as a code owner June 26, 2024 15:04
Copy link

@vijayanjay
Copy link
Contributor Author

/it-go

@vstarostin
Copy link
Member

/it-go

@vijayanjay vijayanjay merged commit 06df2d4 into master Jun 27, 2024
12 checks passed
@vijayanjay vijayanjay deleted the vijayan/npm_exclude_issue branch June 27, 2024 10:36
o-liver pushed a commit that referenced this pull request Jun 28, 2024
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
…ix-fix

* origin/master: (361 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
* origin/master: (421 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
…fig-fix

* origin/master: (460 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
…1.371.0-edp

* origin/whitesource-sbt-config-fix: (462 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Oct 1, 2024
… v1.386.0-edp

* origin/whitesource-sbt-config-fix: (462 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Nov 20, 2024
… v1.406.0-edp

* origin/whitesource-sbt-config-fix: (463 commits)
  allow whitesource sbt args to be overridden
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants