Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vaultDisableOverwrite handling #4990

Merged
merged 3 commits into from
Jul 23, 2024
Merged

fix vaultDisableOverwrite handling #4990

merged 3 commits into from
Jul 23, 2024

Conversation

Googlom
Copy link
Member

@Googlom Googlom commented Jul 19, 2024

Checking types is meaningless here since it will always be true for string parameters. It's reasonable to check value.

@Googlom Googlom requested a review from a team as a code owner July 19, 2024 14:51
@Googlom
Copy link
Member Author

Googlom commented Jul 22, 2024

/it-go

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Googlom
Copy link
Member Author

Googlom commented Jul 22, 2024

/it-go

@Googlom Googlom merged commit a564a12 into master Jul 23, 2024
12 checks passed
@Googlom Googlom deleted the fix_vaultDisableOverwrite branch July 23, 2024 10:43
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into kaniko-context-pref…
e1ff1bb 
…ix-fix

* origin/master: (361 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@Googlom @maxatsap
fix vaultDisableOverwrite handling (SAP#4990)
7dd0078
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into malwarescan-async-scan
c3e0329 
* origin/master: (421 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into whitesource-sbt-con…
12b7a43 
…fig-fix

* origin/master: (460 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@maxatsap
Merge remote-tracking branch origin/whitesource-sbt-config-fix into v…
81aa48d 
…1.371.0-edp

* origin/whitesource-sbt-config-fix: (462 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Oct 1, 2024
@maxatsap
Merge remote-tracking branch 'origin/whitesource-sbt-config-fix' into…
ecd8d32 
… v1.386.0-edp

* origin/whitesource-sbt-config-fix: (462 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Nov 20, 2024
@maxatsap
Merge remote-tracking branch 'origin/whitesource-sbt-config-fix' into…
8d895dd 
… v1.406.0-edp

* origin/whitesource-sbt-config-fix: (463 commits)
  allow whitesource sbt args to be overridden
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jliempt jliempt jliempt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Googlom @jliempt