Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt clone step to work with customer-managed Repos (BYOG) #4966

Merged
merged 38 commits into from
Jun 25, 2024
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
35aad23
adding byog credentials for clone command
doldsimo Jun 11, 2024
eace22e
Merge remote-tracking branch 'upstream/master' into apibyogclone
doldsimo Jun 11, 2024
eb16e7c
adding unit tests for clone body
doldsimo Jun 12, 2024
ecf5ffc
adding parameters
doldsimo Jun 12, 2024
1ff6f2f
adding optional byog parameters
doldsimo Jun 13, 2024
ca3f6c1
fixing typo in username
doldsimo Jun 14, 2024
c7f4687
remove aliases in config yaml
doldsimo Jun 14, 2024
65202b1
change yaml config
doldsimo Jun 14, 2024
0cc82a1
logs
doldsimo Jun 14, 2024
de1c00f
change info log
doldsimo Jun 14, 2024
fa5db99
change logs
doldsimo Jun 14, 2024
c11ba64
remove logs
doldsimo Jun 14, 2024
fe853b9
adding log statements
doldsimo Jun 19, 2024
d2f88d9
remove log statements
doldsimo Jun 19, 2024
9adcf26
fixing typo in test class
doldsimo Jun 19, 2024
5275375
change repoTest structure
doldsimo Jun 19, 2024
b1dab9d
merge master
doldsimo Jun 19, 2024
f77cb4b
remove comment
doldsimo Jun 19, 2024
e92f527
remove comment
doldsimo Jun 19, 2024
df2de60
generate
doldsimo Jun 19, 2024
4f452cd
adding unit test comments
doldsimo Jun 19, 2024
573a19b
adding error handling
doldsimo Jun 20, 2024
a907819
adding isByog check
doldsimo Jun 20, 2024
f091f0c
fixing unit test
doldsimo Jun 20, 2024
2ed8946
generate
doldsimo Jun 20, 2024
c14d990
Merge branch 'master' into apibyogclone
doldsimo Jun 20, 2024
1acc31c
Update manageGitRepositoryUtils_test.go
doldsimo Jun 20, 2024
2282a71
restructure isByog parameter
doldsimo Jun 21, 2024
fa916d9
Merge branch 'apibyogclone' of https://github.com/doldsimo/jenkins-li…
doldsimo Jun 21, 2024
4c67734
adding empty line for md linter
doldsimo Jun 21, 2024
09c79a0
adding config.yaml example to docs
doldsimo Jun 21, 2024
b4e4453
Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md
doldsimo Jun 21, 2024
a95ca04
Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md
doldsimo Jun 21, 2024
47c6cf3
Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md
doldsimo Jun 21, 2024
297c8d5
Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md
doldsimo Jun 21, 2024
f7b3725
Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md
doldsimo Jun 21, 2024
567294f
adding release
doldsimo Jun 21, 2024
a6f25ea
Merge branch 'master' into apibyogclone
DanielMieg Jun 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
  • Loading branch information
doldsimo and DanielMieg authored Jun 21, 2024
commit 297c8d5eb025fe0fba950e1f9e3c6cea5404cea5
2 changes: 1 addition & 1 deletion documentation/docs/steps/abapEnvironmentCloneGitRepo.md
Original file line number Diff line number Diff line change
@@ -120,7 +120,7 @@ steps:
host: '1234-abcd-5678-efgh-ijk.abap.eu10.hana.ondemand.com'
```

`byogCredentialsId: 'byog'` is the reference to the defined credential in Jenkins. So take care that this matches with your setup.
`byogCredentialsId: 'byogCredentialsId'` is the reference to the defined credential in Jenkins. So take care that this matches with your setup.

After that, the byog repository that is to be cloned must be specified in the repos.yaml:
doldsimo marked this conversation as resolved.
Show resolved Hide resolved

Loading