chore(core,platform): styles bump & breaking changes adoption #7987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Visit the preview URL for this PR (updated for commit ee60afd): https://fundamental-ngx-gh--pr7987-pr-chore-styles-bump-lvhh1dd7.web.app (expires Sat, 04 Jun 2022 14:22:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
mikerodonnell89
requested changes
Apr 15, 2022
|
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
platon-rov
force-pushed
the
pr/chore/styles-bump-breaking-changes-adoption
branch
from
f7ce769
to
90b114b
Compare
platon-rov
force-pushed
the
pr/chore/styles-bump-breaking-changes-adoption
branch
from
90b114b
to
9a94bba
Compare
N1XUS
reviewed
Apr 20, 2022
g-cheishvili
force-pushed
the
pr/chore/styles-bump-breaking-changes-adoption
branch
from
9a94bba
to
65fa17d
Compare
platon-rov
force-pushed
the
pr/chore/styles-bump-breaking-changes-adoption
branch
from
845e711
to
5877091
Compare
|
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
N1XUS
force-pushed
the
pr/chore/styles-bump-breaking-changes-adoption
branch
from
0aa79e8
to
c6c33a7
Compare
g-cheishvili
force-pushed
the
pr/chore/styles-bump-breaking-changes-adoption
branch
from
69fdf05
to
1619f36
Compare
|
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
|
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
platon-rov
force-pushed
the
pr/chore/styles-bump-breaking-changes-adoption
branch
from
177aa42
to
04cbfae
Compare
* fix(core,docs): fixed card footer and added list content detection * fix(docs): fixed card footer docs * fix(docs): removed unnecessary tab stop * fix(e2e,core): fixed card tests and classnames for footer * chore(core): fixed incorrect classnames and added missing typedoc * feat(core): added missing parts to the card * chore(deps): added typedocs * chore(deps): updated fundamental styles * fix(core): updated according to review notes and added missing export * fix(e2e): fixed e2e tests * chore(docs): changed directive name * chore(core): added missing typedoc * chore(e2e): fixed failing tests
* chore(core,platform): bump styles to 0.24.0-rc.89 * fix(core): shellbar breaking changes adoption
* chore(deps): bumped fundamental-styles dependency * fix(core): adopted busy indicator breaking changes
* fix(core): additional updates for the panel * fix(core): force build against correct base branch
* fix(core,platform): shellbar breaking changes adoption * fix(core,platform): toolbar breaking changes adoption BREAKING CHANGE: * toolbar title now requires fd-toolbar__title class * fix(core,platform): table breaking changes adoption BREAKING CHANGE: * wrap text in table cell in fd-table-text directive to have the text-shadow * fix(core,platform): calendar breaking changes adoption * fix(core): shellbar action-sheet instead of list * test(core,platform): e2e fixes * fix(docs): fix button type * chore(core,platform): fund styles version bump to v0.24.0-rc.41 * fix(docs): fixed documentation sidebar background color * fix(docs): fixed documentation page compatibility with themes * chore(deps): bumped fundamental-styles * chore(e2e): updated selector for sidenav control * fix(core,platform): fixed split button missing class (#8034) * feat(platform): icon tab bar horizon theme adaptation (#8006) * fix(platform): removed unnecessary more(extra) button directive * fix(platform): fixed unit test * chore(e2e): fixed e2e * chore(core,platform): fund styles version bump to v0.24.0-rc.53 * fix(core,platform): calendar year & month items * test(core): e2e fixes * fix(core): vertical nav styles derivation from styles lib * test(core,platform): e2e fixes for calendar based comps * test(core,platform): e2e fixes for calendar based comps * fix(core,platform): calendar year & months items styling * fix(core): update toolbar and bar for horizon * fix(core,platform): adjust toolbar component for dynamic page (#8052) * feat(core): more toolbar updates * feat(core): more toolbar improvements allowing and documenting both title approaches * fix(core): title token * fix(core): accidental change Co-authored-by: Platon Rov <[email protected]> Co-authored-by: g-cheishvili <[email protected]> Co-authored-by: N1XUS <[email protected]>
* fix(core): carousel fund-styles changes adoption * fix(core): carousel breaking changes adoption * chore(core,platform): styles bump to 0.24.0-rc.100 * chore(core): carousel breaking changes adoption * test(core): carousel e2e
platon-rov
force-pushed
the
pr/chore/styles-bump-breaking-changes-adoption
branch
from
226b473
to
19f7c51
Compare
* fix(core,platform): shellbar breaking changes adoption * feat(core,platform): slider horizon theme Co-authored-by: Platon Rov <[email protected]>
BREAKING CHANGE: * Grid List Item body markup change * The whole item is clickable from now, it might cause issues in single selection mode but selection event emitted first. * Grid List Infobar - whole item is clickable instead of button on it.
* chore(deps): bumped styles version * fix(core): adopted breaking changes * chore(core): removed todo comment
* feat(core): added support for icons in horizon * fix(core): fixed empty slots
* feat(core): added support for icons in horizon * fix(core): fixed empty slots * refactor(core): updated according to the latest modifications from styles * refactor(core): fixed tsdocs * chore(deps): bumped up fundamental-styles version
mikerodonnell89
approved these changes
Jun 2, 2022
N1XUS
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Closes none.
Description
Fund styles version bump, breaking changes adoption. Unblocks issues that depends on the fund styles fixes.
Note: Shellbar's buttons color on hover will be fixed automatically with the SAP/fundamental-styles#3328 where the specificity will be changed for the button component.
Screenshots
Before:
Calendar:
Shellbar:
After:
Calendar:
Shellbar:
Other components haven't been affected visually
BREAKING CHANGE
fd-toolbar__titleclassfd-table-textdirective to have the text-shadow