fix(platform): icon tab bar horizon theme - removed unnecessary more(extra) button directive #8006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-cheishvili
changed the title
|
Visit the preview URL for this PR (updated for commit 0d3d5c5): https://fundamental-ngx-gh--pr8006-fix-icon-tab-bar-hor-dyhju18i.web.app (expires Fri, 29 Apr 2022 18:10:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
platon-rov
force-pushed
the
pr/chore/styles-bump-breaking-changes-adoption
branch
from
845e711
to
5877091
Compare
|
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
platon-rov
force-pushed
the
fix/icon_tab_bar_horizon
branch
from
7769a5d
to
207d5ca
Compare
|
Looks good, but some visual problem (no spacing for the More button) Before: After: |
That's how it should be. Previously position for that button was determined by the |
g-cheishvili
force-pushed
the
fix/icon_tab_bar_horizon
branch
from
3f0c2bc
to
6be42b1
Compare
g-cheishvili
force-pushed
the
fix/icon_tab_bar_horizon
branch
from
6be42b1
to
b5b0fa8
Compare
InnaAtanasova
approved these changes
Apr 26, 2022
platon-rov
approved these changes
Apr 28, 2022
36 tasks
platon-rov
pushed a commit
that referenced
this pull request
May 16, 2022
* fix(platform): removed unnecessary more(extra) button directive * fix(platform): fixed unit test * chore(e2e): fixed e2e
mikerodonnell89
added a commit
that referenced
this pull request
May 20, 2022
* fix(core,platform): shellbar breaking changes adoption * fix(core,platform): toolbar breaking changes adoption BREAKING CHANGE: * toolbar title now requires fd-toolbar__title class * fix(core,platform): table breaking changes adoption BREAKING CHANGE: * wrap text in table cell in fd-table-text directive to have the text-shadow * fix(core,platform): calendar breaking changes adoption * fix(core): shellbar action-sheet instead of list * test(core,platform): e2e fixes * fix(docs): fix button type * chore(core,platform): fund styles version bump to v0.24.0-rc.41 * fix(docs): fixed documentation sidebar background color * fix(docs): fixed documentation page compatibility with themes * chore(deps): bumped fundamental-styles * chore(e2e): updated selector for sidenav control * fix(core,platform): fixed split button missing class (#8034) * feat(platform): icon tab bar horizon theme adaptation (#8006) * fix(platform): removed unnecessary more(extra) button directive * fix(platform): fixed unit test * chore(e2e): fixed e2e * chore(core,platform): fund styles version bump to v0.24.0-rc.53 * fix(core,platform): calendar year & month items * test(core): e2e fixes * fix(core): vertical nav styles derivation from styles lib * test(core,platform): e2e fixes for calendar based comps * test(core,platform): e2e fixes for calendar based comps * fix(core,platform): calendar year & months items styling * fix(core): update toolbar and bar for horizon * fix(core,platform): adjust toolbar component for dynamic page (#8052) * feat(core): more toolbar updates * feat(core): more toolbar improvements allowing and documenting both title approaches * fix(core): title token * fix(core): accidental change Co-authored-by: Platon Rov <[email protected]> Co-authored-by: g-cheishvili <[email protected]> Co-authored-by: N1XUS <[email protected]>
platon-rov
pushed a commit
that referenced
this pull request
May 24, 2022
* fix(platform): removed unnecessary more(extra) button directive * fix(platform): fixed unit test * chore(e2e): fixed e2e
platon-rov
added a commit
that referenced
this pull request
May 24, 2022
* fix(core,platform): shellbar breaking changes adoption * fix(core,platform): toolbar breaking changes adoption BREAKING CHANGE: * toolbar title now requires fd-toolbar__title class * fix(core,platform): table breaking changes adoption BREAKING CHANGE: * wrap text in table cell in fd-table-text directive to have the text-shadow * fix(core,platform): calendar breaking changes adoption * fix(core): shellbar action-sheet instead of list * test(core,platform): e2e fixes * fix(docs): fix button type * chore(core,platform): fund styles version bump to v0.24.0-rc.41 * fix(docs): fixed documentation sidebar background color * fix(docs): fixed documentation page compatibility with themes * chore(deps): bumped fundamental-styles * chore(e2e): updated selector for sidenav control * fix(core,platform): fixed split button missing class (#8034) * feat(platform): icon tab bar horizon theme adaptation (#8006) * fix(platform): removed unnecessary more(extra) button directive * fix(platform): fixed unit test * chore(e2e): fixed e2e * chore(core,platform): fund styles version bump to v0.24.0-rc.53 * fix(core,platform): calendar year & month items * test(core): e2e fixes * fix(core): vertical nav styles derivation from styles lib * test(core,platform): e2e fixes for calendar based comps * test(core,platform): e2e fixes for calendar based comps * fix(core,platform): calendar year & months items styling * fix(core): update toolbar and bar for horizon * fix(core,platform): adjust toolbar component for dynamic page (#8052) * feat(core): more toolbar updates * feat(core): more toolbar improvements allowing and documenting both title approaches * fix(core): title token * fix(core): accidental change Co-authored-by: Platon Rov <[email protected]> Co-authored-by: g-cheishvili <[email protected]> Co-authored-by: N1XUS <[email protected]>
platon-rov
pushed a commit
that referenced
this pull request
May 26, 2022
* fix(platform): removed unnecessary more(extra) button directive * fix(platform): fixed unit test * chore(e2e): fixed e2e
platon-rov
added a commit
that referenced
this pull request
May 26, 2022
* fix(core,platform): shellbar breaking changes adoption * fix(core,platform): toolbar breaking changes adoption BREAKING CHANGE: * toolbar title now requires fd-toolbar__title class * fix(core,platform): table breaking changes adoption BREAKING CHANGE: * wrap text in table cell in fd-table-text directive to have the text-shadow * fix(core,platform): calendar breaking changes adoption * fix(core): shellbar action-sheet instead of list * test(core,platform): e2e fixes * fix(docs): fix button type * chore(core,platform): fund styles version bump to v0.24.0-rc.41 * fix(docs): fixed documentation sidebar background color * fix(docs): fixed documentation page compatibility with themes * chore(deps): bumped fundamental-styles * chore(e2e): updated selector for sidenav control * fix(core,platform): fixed split button missing class (#8034) * feat(platform): icon tab bar horizon theme adaptation (#8006) * fix(platform): removed unnecessary more(extra) button directive * fix(platform): fixed unit test * chore(e2e): fixed e2e * chore(core,platform): fund styles version bump to v0.24.0-rc.53 * fix(core,platform): calendar year & month items * test(core): e2e fixes * fix(core): vertical nav styles derivation from styles lib * test(core,platform): e2e fixes for calendar based comps * test(core,platform): e2e fixes for calendar based comps * fix(core,platform): calendar year & months items styling * fix(core): update toolbar and bar for horizon * fix(core,platform): adjust toolbar component for dynamic page (#8052) * feat(core): more toolbar updates * feat(core): more toolbar improvements allowing and documenting both title approaches * fix(core): title token * fix(core): accidental change Co-authored-by: Platon Rov <[email protected]> Co-authored-by: g-cheishvili <[email protected]> Co-authored-by: N1XUS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed more button directive, because recalculations are not required anymore, button is not absolute