Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): quick view background, requires corresponding PR in styles #8114

Conversation

mikerodonnell89
Copy link
Member

Changes required to accompany the merge of SAP/fundamental-styles#3443

This branch will require a styles version bump as well

@mikerodonnell89 mikerodonnell89 added the bug Something isn't working label May 18, 2022
@mikerodonnell89 mikerodonnell89 requested a review from a team May 18, 2022 21:06
@mikerodonnell89 mikerodonnell89 self-assigned this May 18, 2022
@github-actions
Copy link

github-actions bot commented May 18, 2022

Visit the preview URL for this PR (updated for commit 6c2c432):

https://fundamental-ngx-gh--pr8114-fix-quick-view-backg-6lzpzgwf.web.app

(expires Tue, 31 May 2022 16:02:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@mikerodonnell89 mikerodonnell89 changed the title [blocked] fix(core): quick view background, requires corresponding PR in styles fix(core): quick view background, requires corresponding PR in styles May 20, 2022
@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label May 23, 2022
@platon-rov platon-rov force-pushed the pr/chore/styles-bump-breaking-changes-adoption branch from 38e5902 to 226b473 Compare May 24, 2022 07:43
@N1XUS
Copy link
Contributor

N1XUS commented May 26, 2022

@mikerodonnell89 please check failing tests

@platon-rov platon-rov force-pushed the pr/chore/styles-bump-breaking-changes-adoption branch from 226b473 to 19f7c51 Compare May 26, 2022 15:17
@platon-rov platon-rov merged commit b5a53e3 into pr/chore/styles-bump-breaking-changes-adoption May 28, 2022
@platon-rov platon-rov deleted the fix/quick-view-background branch May 28, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants