Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): grid list horizon, styles breaking changes adoption #8039

Merged
merged 10 commits into from
May 28, 2022
Merged

feat(core): grid list horizon, styles breaking changes adoption #8039

merged 10 commits into from
May 28, 2022

Conversation

platon-rov
Copy link
Contributor

@platon-rov platon-rov commented Apr 29, 2022 •
edited
Loading

Related Issue(s)

Closes none.

Description

Grid List Horizon support, breaking changes adoption.

Screenshots

Before:

image

After:

Blocked by SAP/fundamental-styles#3374

image

BREAKING CHANGE

  • Grid List Item body markup changed, see wiki
  • The whole item with link is clickable now, it might cause issues in a single selection mode but selection event emitted first.

https://github.com/SAP/fundamental-ngx/wiki/0.35.0-Breaking-changes#grid-list-core-8039

@platon-rov platon-rov added the core Core library specific issues label Apr 29, 2022
@platon-rov platon-rov self-assigned this Apr 29, 2022
@platon-rov platon-rov requested review from a team April 29, 2022 11:00
@github-actions
Copy link

github-actions bot commented Apr 29, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit 5e032ce):

https://fundamental-ngx-gh--pr8039-pr-feat-grid-list-ho-akdtl9uu.web.app

(expires Tue, 31 May 2022 15:22:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

InnaAtanasova
InnaAtanasova requested changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, approved by accident :)
Screen Shot 2022-04-29 at 1 27 14 PM

You can't have this in Fundamental-ngx. You need to convert these to directives.

Why is [innerText] used in these cases? Can't we avoid it? I believe there are security problems using this approach???

@InnaAtanasova InnaAtanasova added this to the Sprint 87 - Tirana milestone Apr 29, 2022
@github-actions
Copy link

github-actions bot commented May 2, 2022

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label May 2, 2022
@platon-rov platon-rov removed the stale label May 2, 2022
@platon-rov platon-rov changed the title feat(core): grid list horizon, styles breaking changes adoption [WIP] feat(core): grid list horizon, styles breaking changes adoption May 2, 2022
@platon-rov platon-rov added the blocked blocked ticket label May 5, 2022
@github-actions
Copy link

github-actions bot commented May 8, 2022

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label May 8, 2022
@github-actions github-actions bot closed this May 11, 2022
@platon-rov platon-rov changed the title [WIP] feat(core): grid list horizon, styles breaking changes adoption feat(core): grid list horizon, styles breaking changes adoption May 13, 2022
@platon-rov platon-rov reopened this May 13, 2022
@platon-rov platon-rov added enhancement New feature or request and removed blocked blocked ticket stale labels May 13, 2022
@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label May 16, 2022
@platon-rov platon-rov removed the stale label May 16, 2022
@platon-rov platon-rov force-pushed the pr/chore/styles-bump-breaking-changes-adoption branch from 177aa42 to 04cbfae Compare May 16, 2022 08:34
@g-cheishvili
Copy link
Contributor

Git Log is messed up. probably you force-pushed into target branch and now it shows enormous amount of changes. Needs your intervention @platon-rov

@platon-rov platon-rov mentioned this pull request May 17, 2022
Closed
91 tasks
@platon-rov
Copy link
Contributor Author

[BLOCKED] by SAP/fundamental-styles#3430

@platon-rov platon-rov added the blocked blocked ticket label May 18, 2022
@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label May 21, 2022
@platon-rov platon-rov removed the stale label May 23, 2022
@platon-rov platon-rov force-pushed the pr/chore/styles-bump-breaking-changes-adoption branch 2 times, most recently from 226b473 to 19f7c51 Compare May 26, 2022 15:17
@platon-rov platon-rov removed the blocked blocked ticket label May 26, 2022
@platon-rov platon-rov merged commit 4b075ee into pr/chore/styles-bump-breaking-changes-adoption May 28, 2022
@platon-rov platon-rov deleted the pr/feat/grid-list-horizon branch May 28, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@platon-rov platon-rov

Labels
core Core library specific issues enhancement New feature or request
Projects
None yet
Milestone
Sprint 88 - Kharkiv
Development

Successfully merging this pull request may close these issues.
3 participants
@platon-rov @g-cheishvili @InnaAtanasova