Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): toolbar info mode styling, grid list toolbar #3430

Merged
merged 2 commits into from
May 25, 2022
Merged

fix(styles): toolbar info mode styling, grid list toolbar #3430

merged 2 commits into from
May 25, 2022

Conversation

platon-rov
Copy link
Contributor

Related Issue

Part of #3327 (comment)

Description

Toolbar Infobar mode styling change.
Grid List Toolbar Infobar usage adoption.

Screenshots

Before:

image

After:

image

BREAKING CHANGE:

  • Grid list info bar markup change

@platon-rov platon-rov added Bug Something isn't working Horizon Delta labels May 16, 2022
@platon-rov platon-rov requested a review from a team May 16, 2022 10:19
@platon-rov platon-rov self-assigned this May 16, 2022
@platon-rov platon-rov mentioned this pull request May 16, 2022
Closed
50 tasks
@netlify
Copy link

netlify bot commented May 16, 2022 •
edited
Loading

✅ Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit d469111
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/628c8adde7029d00088d2703
😎 Deploy Preview https://deploy-preview-3430--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

N1XUS
N1XUS suggested changes May 16, 2022
View reviewed changes
Copy link
Contributor

@N1XUS N1XUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add [ci visual] to last commit message

mikerodonnell89
mikerodonnell89 requested changes May 17, 2022
View reviewed changes
Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get both the black dotted and the blue focus outline when I tab to the grid list toolbar:
Screen Shot 2022-05-17 at 1 49 18 PM

@platon-rov platon-rov mentioned this pull request May 18, 2022
Merged
@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label May 21, 2022
@platon-rov platon-rov removed the stale label May 23, 2022
@platon-rov platon-rov merged commit e63ca0c into main May 25, 2022
@platon-rov platon-rov deleted the pr/fix/toolbar-info branch May 25, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-cheishvili g-cheishvili g-cheishvili approved these changes

@N1XUS N1XUS N1XUS approved these changes

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

Assignees

@platon-rov platon-rov

Labels
Bug Something isn't working Horizon Delta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@platon-rov @mikerodonnell89 @N1XUS @g-cheishvili