Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from Upstream #4

Merged
merged 35 commits into from
Sep 12, 2020
Merged

Update from Upstream #4

merged 35 commits into from
Sep 12, 2020

Commits on Sep 2, 2020

  1. smartxBidAdapter.js - removed unused variables, removed debug, added …

    …window before the outstream related functions (#5689)
    
    Co-authored-by: Gino <[email protected]>
    smartclip-adtech and Skylinar authored Sep 2, 2020
    Configuration menu
    Copy the full SHA
    bba4b02 View commit details
    Browse the repository at this point in the history
  2. Prebid 4.6.0 Release

    Jaimin Panchal committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    6842e8b View commit details
    Browse the repository at this point in the history
  3. Increment pre version

    Jaimin Panchal committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    e783c75 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. parrableIdSystem: Add an optional timezone and timezone offset allow/…

    …block filter (#5569)
    
    * Add unit coverage for parrableIdSystem getId callback
    
    * PBID-14: Pass uspString to Parrable as us_privacy query parameter
    
    * PBID-14: Simplify parrableIdSystem us_privacy test
    
    * PBID-14: Only send us_privacy to Parrable when a value exists
    
    * PBID-11: Read new Parrable compound cookie _parrable_id
    
    Migrating from legacy _parrable_eid cookie. The new cookie contains ibaOptout and ccpaOptout status fields
    
    * Remove path check from parrableIdSystem url test
    
    * PBID-11: Integrate Parrable compound cookie, consolidating old cookies
    
    * PBID-11: Update parrableIdSystem requestBids hook test to support compound cookie value
    
    * PBID-11: Small refactor to parrableIdSystem spec to support compound cookie
    
    * PBID-11: Handle legacy ibaOptout as truthy value when migrating to compound cookie
    
    * PBID-11: Add parrableIdSystem spec tests covering migration of legacy cookies
    
    * PBID-11: Remove storage documentation from test pages and userId module docs
    
    * PBID-11: Remove SUBMODULES_THAT_ALWAYS_REFRESH_ID feature from userId system
    
    * PBID-11: Use better serialize implementation for Parrable compound cookie
    
    * PBID-11: Update parrableIdSystem interface documentation
    
    * Add missing extension to mock xhr import
    
    * PBID-11: Try to access eid property only when parrableId object exists
    
    * PBID-11: Construct parrableId from legacy cookies in same manner as compound cookie
    
    * Use hardcoded expiration date for legacy cookies
    
    * PBID-39: Return full parrableId object in decode method
    
    * PBID-39: Update all adapters to use parrableId.eid for userId value
    
    * PBID-39: Update config for ORTB EIDs to extract parrableId.eid as User UID value
    
    * PBID-39: Pass Parrable IBA and CCPA optout status into ORTB EIDs list through UID extensions
    
    * PBID-39: Pass a true CCPA optout status to adapters when the EID has been suppressed
    
    The userId/eids module will not consider our ID system for inclusion in the EIDs object if our ID value is not a string.
    Unfortunately when we write our cookie without an EID (in the case where CCPA optout is true) then the deserialized EID value is undefined, to save space in the cookie.
    
    So this is a hack that will return an empty string when Prebid is building the EIDs object so that we can still pass our optout status to those that require it to understand why our ID may be missing.
    
    * parrableIdSystem: Relocate new unit test from upstream
    
    * PBID-39: Fallback to cookie values when backend response is missing components
    
    Also handle another missed callback scenario if the response object parses to nothing
    
    * PBID-39: Avoid breaking openx bid adapter when renaming our id system
    
    * PBID-39: Use array find
    
    * Use supported array find method in parrableIdSystem_spec
    
    * Restore backwards-compatible parrableId passing to OpenxBidAdapter
    
    * PBID-25: Add time zone and offset filtering of impressions to parrableIdSystem
    
    * PBID-25: Better group existing getId tests
    
    * PBID-25: Add unit tests covering time zone and offset filtering functionality
    
    * PBID-25: Remove parrable .only test scope
    icflournoy authored Sep 3, 2020
    Configuration menu
    Copy the full SHA
    deb7d5b View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Blue Billywig bid adapter update (#5584)

    * add Blue Billywig adapter
    
    * Blue Billywig Adapter - update according to review feedback
    
    * Blue Billywig Adapter - update to try and pass CircleCI
    
    * Remove the last for .. of in bluebillywigBidAdapter.js, hopefully...
    
    * Code quality update, always hit user syncs, improved video params
    
    Co-authored-by: Klaas-Jan Boon <[email protected]>
    Co-authored-by: Klaas-Jan Boon <[email protected]>
    3 people authored Sep 4, 2020
    Configuration menu
    Copy the full SHA
    7743713 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2020

  1. Vidazoo Adapter: refactor/user-sync (#5654)

    * feat(module): multi size request
    
    * fix getUserSyncs
    added tests
    
    * update(module): package-lock.json from master
    
    * feat(client): initial refactor commit
    
    * fix(client): lint issues
    
    Co-authored-by: roman <[email protected]>
    uditalias and shmoop207 authored Sep 5, 2020
    Configuration menu
    Copy the full SHA
    9626398 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2020

  1. New Bid Adapter: a4g (#5688)

    * Updated a4g adapter
    
    * use https and mediaTypes sizes
    Junus authored Sep 7, 2020
    Configuration menu
    Copy the full SHA
    783a3bb View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Adding errors event listener (#5563)

    * Adding errors event listener
    
    * Changed event name to 'auctionDebug', with 'type' property, to support future debug event types.
    
    * Update AnalyticsAdapter.js
    
    * Update AnalyticsAdapter_spec.js
    
    * Update AnalyticsAdapter_spec.js
    
    * Update AnalyticsAdapter.js
    
    * Removed trailing spaces
    
    * fixed tests assertion to handle new error events
    
    * Fixed analytics test to expect auctionDebug event too
    
    * Update yuktamediaAnalyticsAdapter_spec.js
    
    * Removed port dependency on readpeak adapter's test
    
    Co-authored-by: Patrick McCann <[email protected]>
    ofirpaBrowsi and patmmccann authored Sep 8, 2020
    Configuration menu
    Copy the full SHA
    cacb5eb View commit details
    Browse the repository at this point in the history
  2. Prebid 4.7.0 Release

    smenzer committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    33e1691 View commit details
    Browse the repository at this point in the history
  3. added adapters for gjirafa and malltv (#5587)

    * added adapters for gjirafa and malltv
    
    * interpretResponse fix for empty result
    
    * updated testing propertyId and placementId
    drilon-kastrati authored Sep 8, 2020
    Configuration menu
    Copy the full SHA
    bcf7b5a View commit details
    Browse the repository at this point in the history
  4. minor validation update to consentManagement.js (#5701)

    Co-authored-by: Eric Harper <[email protected]>
    harpere and Eric Harper authored Sep 8, 2020
    Configuration menu
    Copy the full SHA
    c3c04f5 View commit details
    Browse the repository at this point in the history
  5. New Bid Adapter: decenterads (#5711)

    * add new version decenteradsBidAdapter.js
    
    * add new version decenteradsBidAdapter_spec.js
    
    * add .js to import
    
    * replace method getWindowLocation
    
    * replace urls
    
    Co-authored-by: vlad <[email protected]>
    vlaktion and vlad authored Sep 8, 2020
    Configuration menu
    Copy the full SHA
    44a3797 View commit details
    Browse the repository at this point in the history
  6. fix GPT Pre-Auction PBS path (#5650)

    * Add microadBidAdapter
    
    * Remove unnecessary encodeURIComponent from microadBidAdapter
    
    * Submit Advangelists Prebid Adapter
    
    * Submit Advangelists Prebid Adapter 1.1
    
    * Correct procudtion endpoint for prebid
    
    * analytics update with wrapper name
    
    * reverted error merge
    
    * update changed default value of netRevenue to true
    
    * Re-add rubicon analytics without deprecated getTopWindowUrl util
    
    * Cache referrer on auction_init instead of bid_requested
    
    * merged remote master changes
    
    * updated unit tests for object path changes
    
    * updated rp bid adapter unit tests for GAM object path changes
    
    * updated naming and changed iterator to use arrow syntax
    
    * continue renaming and cleanup
    
    Co-authored-by: nakamoto <[email protected]>
    Co-authored-by: Chandra Prakash <[email protected]>
    Co-authored-by: Eric Harper <[email protected]>
    Co-authored-by: TJ Eastmond <[email protected]>
    Co-authored-by: Mark Monday <[email protected]>
    Co-authored-by: msm0504 <[email protected]>
    7 people authored Sep 8, 2020
    Configuration menu
    Copy the full SHA
    1676c76 View commit details
    Browse the repository at this point in the history
  7. Increment pre version

    smenzer committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    22ce19f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d41a946 View commit details
    Browse the repository at this point in the history
  9. GumGumBidAdapter: Add support for multiple sizes (#5626)

    add UT
    
    
    UT
    
    Co-authored-by: Estavillo <[email protected]>
    estavillo and Estavillo authored Sep 8, 2020
    Configuration menu
    Copy the full SHA
    0d3c632 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Add host to gulpfile (#5710)

    * Add host to gulpfile
    
    * Edit arg.host to FAKE_SERVER_HOST
    
    Co-authored-by: VasekProchazka <[email protected]>
    VasekProchazka and VasekProchazka authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    05283d0 View commit details
    Browse the repository at this point in the history
  2. Move test and publisherId parameters to bidder specific config (#5692)

    Co-authored-by: Yevhenii Tykhostup <[email protected]>
    frstua and Yevhenii Tykhostup authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    b96c1cc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3726fd6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3c9e42f View commit details
    Browse the repository at this point in the history
  5. PubWise.io Analytics Module Update - SPOT Support, Module Rules & Min…

    …or Features (#5677)
    
    * updates to bring module up to current module rules, lints, etc. also add activationId and improve tests
    
    * fix eslint error
    
    * Fix IE11 Includes Check Failing Tests
    
    * revert debug setting
    
    * updates to fix PR review issues
    
    * updates to fix default params handling
    GLStephen authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    b071457 View commit details
    Browse the repository at this point in the history
  6. update amx bid adapter (#5605)

    * add support for RTI adapters/userID
    * add coppa support
    * add first party data support
    * more flexibility in sizes
    * enable reporting by ad unit ID
    * document ad unit ID
    * add bid request count data to the request
    nickjacob authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    565d329 View commit details
    Browse the repository at this point in the history
  7. Add Pub-X Bid adapter (#5676)

    * add Pub-X Bid Adapter
    
    * add Pub-X Bid Adapter
    
    * remove alias
    Pub-X authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    85cf495 View commit details
    Browse the repository at this point in the history
  8. New adapter "Cointraffic" added (#5695)

    * New adapter "Cointraffic" added
    
    * removed mobile detection
    
    * The sizes property has been updated, added supportedMediaTypes.
    stsepelin authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    9a92a22 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Send GDPR data in analytics request (#5653)

    * Livewrapped bid and analytics adapter
    
    * Fixed some tests for browser compatibility
    
    * Fixed some tests for browser compatibility
    
    * Changed analytics adapter code name
    
    * Fix double quote in debug message
    
    * modified how gdpr is being passed
    
    * Added support for Publisher Common ID Module
    
    * Corrections for ttr in analytics
    
    * ANalytics updates
    
    * Auction start time stamp changed
    
    * Detect recovered ad blocked requests
    Make it possible to pass dynamic parameters to adapter
    
    * Collect info on ad units receiving any valid bid
    
    * Support for ID5
    Pass metadata from adapter
    
    * Typo in test + eids on wrong level
    
    * Fix for Prebid 3.0
    
    * Fix get referer
    
    * http -> https in tests
    
    * Native support
    
    * Read sizes from mediatype.banner
    
    * Revert accidental commit
    
    * Support native data collection + minor refactorings
    
    * Set analytics endpoint
    
    * Support for app parameters
    
    * Fix issue where adunits with bids were not counted on reload
    
    * Send debug info from adapter to external debugger
    
    * SChain support
    
    * Send GDPR data in analytics request
    bjorn-lw authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    a2da917 View commit details
    Browse the repository at this point in the history
  2. GDPR Enforcement - Bugfix (#5686)

    * consolicate getGVLID function into a single function
    
    * pass correct arguments to gvlid getter functions
    
    * have one master getGvlid getter function to rule other gvlId getter functions
    
    * restore to file state on master branch
    
    * remove unnecessary example
    
    * remove unnecessary reference from internal object
    
    * works on comments and change getgvlidForAnalyticds Adapter to a one liner
    Fawke authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    8f249dc View commit details
    Browse the repository at this point in the history
  3. changes SameSite from None to Lax for tests on Chrome 85.0.4183 which…

    … added rejection of insecure SameSite=None cookies (#5719)
    bansawbanchee authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    2acca6f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c01cab1 View commit details
    Browse the repository at this point in the history
  5. allow publisher to define backup renderer (#5638)

    * Update Renderer.js
    * Update auction.js
    * Update renderer_spec.js
    * Update auctionmanager_spec.js
    * Update prebidServerBidAdapter_spec.js
    patmmccann authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    466b49e View commit details
    Browse the repository at this point in the history
  6. Automatad Bid Adapter: Support multiple bids in response (#5699)

    * added automatad bid adapter
    
    * added automatad bid adapter readme
    
    * added automatad bidder adapter unit test
    
    * updated maintainer email id for automatad adapter
    
    * refactored automatadBidAdapter js
    
    * refactored automatadBidAdapter unit test
    
    * refactored automatadBidAdapter unit test
    
    * added usersync code to automatad bid adapter
    
    * Added unit test for onBidWon in automatadBidAdapter_spec
    
    * removed trailing spaces
    
    * removed trailing space
    
    * changes for getUserSync function
    
    * lint error fixes
    
    * updated usersync url
    
    * additional test for onBidWon function added
    
    * added ajax stub in test
    
    * updated winurl params
    
    * lint fixes
    
    * added adunitCode in bid request
    
    * added test for adunit code
    
    * add placement in impression object
    
    * added code to interpret multiple bid response in seatbid
    kanchika-kapoor authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    22bb758 View commit details
    Browse the repository at this point in the history
  7. Fix: check mandatory video params (#5470)

    * Fix: check mandatory video params
    
    * Simplifying mediaType video existence check
    cabama authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    277fb9b View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. add verizon alias to aol (#5722)

    * add verizon alias to aol
    
    * Update aolBidAdapter.js
    ETNOL authored Sep 11, 2020
    Configuration menu
    Copy the full SHA
    3c6e075 View commit details
    Browse the repository at this point in the history
  2. Add prebid version to ad-server call (#5730)

    Co-authored-by: Dmitriy Labuzov <[email protected]>
    arconamagi and ym-dlabuzov authored Sep 11, 2020
    Configuration menu
    Copy the full SHA
    ba8ef86 View commit details
    Browse the repository at this point in the history
  3. Zeotap ID+ submodule (#5640)

    * IDU-117 IDU-119 Add zeotap submodule
    
    * IDU-117 IDU-119 Add tests for zeotapId+ module
    
    * add zeotapId+ module spec
    
    * Add IDP base64 decode logic
    
    * remove unwanted file changes
    
    * rename zeotapId+ to zeotapIdPlus
    
    * add zeotapIdPlus submodule to submodules.json
    
    * refactor code for requested changes: remove storage from configParams
    
    * add tests to eids_spec
    
    * rebase n resolve conflicts
    shikharsharma-zeotap authored Sep 11, 2020
    Configuration menu
    Copy the full SHA
    1e9be73 View commit details
    Browse the repository at this point in the history
  4. Prebid Server returns exp rather than ttl (#5715)

    Updating how pbsBidAdapter sets the "TTL" for bids. 
    
    TTL in PBJS terms is how long the bid can stay in cache. However, the OpenRTB standard location for this value is `exp`.
    bretg authored Sep 11, 2020
    Configuration menu
    Copy the full SHA
    896cc0f View commit details
    Browse the repository at this point in the history