PBS Bid Adapter: Pass video.placement when context is instream (#5687) #5716
Conversation
robertrmartinez
changed the title
| @@ -509,6 +509,22 @@ describe('S2S Adapter', function () { | |||
| expect(requestBid.imp[0].video).to.not.exist; | |||
| }); | |||
|
|
|||
| it('should default video placement if not defined and instream', function () { | |||
There was a problem hiding this comment.
Shouldn't the test description be, "should set default video placement if "placement" not defined in instream".
What happens if context is Outstream? I understand, in case of instream, the value of mediaTypes.video.placement should be 1, but, in the case of Outstream, what should be the value ofmediaTypes.video.placement.
There was a problem hiding this comment.
in the case of Outstream, what should be the value ofmediaTypes.video.placement
It should not default / add anything if context is outstream
The Video Taskforce is going to review all video params (including placement) and document those that need to be added to the current list of required fields. ^^ @mike-chowla In the meantime, I don't think any docs are necessary for this PR. |
This reverts commit c9f52b7.
#5687
Type of change
Description of change
If adUnit is video and context is instream and placement is not defined, set it to 1.