PubWise.io Analytics Module Update - SPOT Support, Module Rules & Minor Features

[GLStephen]

Type of change

• [ X ] Feature

Description of change

• Refactor to make compliant with current module rules
• Addition of ActivationID
• Event batching, sessions, etc. to support Smart Path Optimization Technology
• Improvements to testing
• Support new event types

Test Params

 pbjs.enableAnalytics({
  provider: 'pubwise',
  options: {
    site: 'b1ccf317-a6fc-428d-ba69-0c9c208aa61c'    
  }
 });

[GLStephen]

I'm converting this to a draft while we figure out the Browserstack issue.

[musikele]

Test coverage is at 78%, lower than our accepted minimum that is 80%. Please try to improve line coverage the best you can

[musikele]

have a look at suggestions i left regarding the code.

[GLStephen]

@musikele thanks for the review, the storageManager removal was a regression. We'll get that fixed and look at the other items.

[GLStephen]

@musikele Updates have been made. Let me know if you need anything further.

[musikele]

Hi @GLStephen , found another issue while testing this functionality. If I configure the adapter with default values as specified in docs, I get network errors in console. Can you have a look at it?

[musikele]

So, I have probably found an issue here. Based on the docs you've written at the top of this file, I added these lines to my test page:

pbjs.enableAnalytics({
          provider: "pubwise",
          options: {
            site: "test-test-test-test",
          },
        });

when the execution gets here, configOptions.endpoint was set to defaultUrl, but that gets removed by this assignment:

configOptions = config.options;

As a result, i see a bunch of errors in console:

POST http://localhost:9999/integrationExamples/gpt/undefined 405 (Method Not Allowed)
(anonymous) @ ajax.js:91
flushEvents @ pubwiseAnalyticsAdapter.js:171
...
Prebid ERROR: xhr error null Method Not Allowed

Note the undefined at the end of the url.

So, configOptions.endpoint does not exist anymore.

I think you wanted to extend configOptions with the data coming from function arguments:

configOptions = {
    ...configOptions, 
    ...config.options  
}

(This can be also achieved by using Object.assign)

Can you have a look into this?

[GLStephen]

@musikele this is resolved now

[GLStephen]

@musikele thanks for the catch on that, I've also updated to use a reserved ID for testing so that the API will return proper responses, so the old test-test-test-test will now return an "over quota" response.

[musikele]

LGTM