-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: check mandatory video params #5470
Conversation
@afewcc have you had a chance to review this yet? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@aleksatr would you mind taking a look here, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can't read media types from only params anymore..
|
LGTM ty |
* Fix: check mandatory video params * Simplifying mediaType video existence check
This reverts commit 2d32072.
Co-authored-by: Miguel Angel Moreno [email protected]
Type of change
Description of change
Fix: check mandatory video params when there are multiple supply types.
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide: