Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: check mandatory video params #5470

Merged
merged 2 commits into from
Sep 10, 2020
Merged

Fix: check mandatory video params #5470

merged 2 commits into from
Sep 10, 2020

Conversation

cabama
Copy link
Contributor

@cabama cabama commented Jul 8, 2020

Co-authored-by: Miguel Angel Moreno [email protected]

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Fix: check mandatory video params when there are multiple supply types.

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

@smenzer
Copy link
Collaborator

smenzer commented Jul 23, 2020

@afewcc have you had a chance to review this yet?

@stale
Copy link

stale bot commented Aug 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 16, 2020
@cabama
Copy link
Contributor Author

cabama commented Aug 17, 2020

hi! @afewcc @smenzer could you give it a check? Thank you!

@stale stale bot removed the stale label Aug 17, 2020
@smenzer
Copy link
Collaborator

smenzer commented Aug 17, 2020

@aleksatr would you mind taking a look here, please?

Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can't read media types from only params anymore..

@cabama
Copy link
Contributor Author

cabama commented Aug 31, 2020

you can't read media types from only params anymore..
sorry @patmmccann, I do not understand what you mean, can you please elaborate the comment?

@patmmccann
Copy link
Collaborator

LGTM ty

@smenzer smenzer assigned ncolletti and unassigned aleksatr Sep 9, 2020
@ncolletti ncolletti merged commit 277fb9b into prebid:master Sep 10, 2020
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
* Fix: check mandatory video params

* Simplifying mediaType video existence check
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants