Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to labstack echo v4 #216

Closed
loleg opened this issue Mar 24, 2021 · 4 comments
Closed

Update to labstack echo v4 #216

loleg opened this issue Mar 24, 2021 · 4 comments
Assignees
@loleg
Labels
backend Pull requests that update Go code

Comments

@loleg
Copy link
Contributor

loleg commented Mar 24, 2021 •
edited
Loading

As part of the update #214 we are hitting this error during a Go packages update. This points to the need to upgrade to a more recent (v4) version of labstack/echo framework.

# github.com/ProxeusApp/proxeus-core/main/www
main/www/session.go:23:27: cannot use session.Middleware(sessionStore) (type "github.com/labstack/echo/v4".MiddlewareFunc) as type "github.com/labstack/echo".MiddlewareFunc in return argument
main/www/session.go:36:27: cannot use c (type *Context) as type "github.com/labstack/echo/v4".Context in argument to session.Get:
	*Context does not implement "github.com/labstack/echo/v4".Context (wrong type for Echo method)
		have Echo() *"github.com/labstack/echo".Echo
		want Echo() *"github.com/labstack/echo/v4".Echo
@loleg
Copy link
Contributor Author

loleg commented Mar 24, 2021 •
edited
Loading

This seems related to labstack/echo#1517

A go mod why points to the likely cause being what is described in labstack/echo-contrib#16

It's going to be bigger change to migrate to echo v4, so for now I'm going to fix the version to v3. This is done by replacing the echo-contrib version to release 0.5.2 that is the last that depends on a pre-v4 version of echo.

@loleg loleg changed the title Build update issue with labstack echo v4 Update to labstack echo v4 Mar 24, 2021
@loleg loleg added the enhancement New feature or request label Mar 24, 2021
loleg added a commit to loleg/proxeus-core that referenced this issue Mar 24, 2021
@loleg
echo-contrib locked to echo v3 ProxeusApp#216
cf9bef6
@loleg loleg mentioned this issue Mar 24, 2021
Merged
loleg added a commit that referenced this issue Apr 30, 2021
@loleg
Update Go-Ethereum (#214)
3994324 
* Refactored start docs

* Changed source of go-bindata #197

* Updated go dep trackers

* Updated yarn dependencies

* Added update step to Makefile

* New auto-generated bindata tests

* Added doc note about make update

* yarn upgrade

* Doc: rename Infura key as "project ID" for clarity

* Set resource class to medium for CircleCI builds

* Use Debian 'stable' release in Docker

* Add .env configuration loader to make #204

* Copy env during bootstrap

* Documentation related to license finder

* go-bindata install path

* Docker documentation link

* README revised

* Added logging instruction

* Dependency updates, tidy and fix #213

* Documentation tips added

* Yarn update

* Added versioned ssri & is-svg to ui/core

* File type to sync Map #215

* echo-contrib locked to echo v3 #216

* Fix make circular dependency on bindata.go warning

* Switch to CircleCI next gen image #202

* Skip compilation in cloud deploy

* Update to Go 1.16 #217

* Fixed go-bindata install

* Better test for window.web3 #199

* Reverted to legacy CircleCI image

* Revert to new image and new go-bindata load strategy #202

* Fix use of mongo.IndexModel #218

* Update to Node.js LTS 14.x #217

* Improve test for window.web3 #199

* Use same image for build-ui #217

* Updated ui library web3 1.3.4 #199

* Go mod tidy
loleg added a commit that referenced this issue Dec 10, 2021
@loleg @m-javani
Frontend build upgrade (#237)
5f6dfd2 
* Refactored start docs

* Changed source of go-bindata #197

* Updated go dep trackers

* Updated yarn dependencies

* Added update step to Makefile

* New auto-generated bindata tests

* Added doc note about make update

* yarn upgrade

* Doc: rename Infura key as "project ID" for clarity

* Set resource class to medium for CircleCI builds

* Use Debian 'stable' release in Docker

* Add .env configuration loader to make #204

* Copy env during bootstrap

* Documentation related to license finder

* go-bindata install path

* Docker documentation link

* README revised

* Added logging instruction

* Dependency updates, tidy and fix #213

* Documentation tips added

* Yarn update

* Added versioned ssri & is-svg to ui/core

* File type to sync Map #215

* echo-contrib locked to echo v3 #216

* Fix make circular dependency on bindata.go warning

* Switch to CircleCI next gen image #202

* Skip compilation in cloud deploy

* Update to Go 1.16 #217

* Fixed go-bindata install

* Better test for window.web3 #199

* Reverted to legacy CircleCI image

* Revert to new image and new go-bindata load strategy #202

* Fix use of mongo.IndexModel #218

* Update to Node.js LTS 14.x #217

* Improve test for window.web3 #199

* Use same image for build-ui #217

* Updated ui library web3 1.3.4 #199

* Go mod tidy

* Minor ui linting fix

* Go library upgrade: mongo-driver, goja

* Upgrade @vue/cli-service from 3.12.1 to 4.5.12

* Auto-conversion to ES6 syntax #220

* Switch cli to dev dependencies

* Remove eth-lightwallet #220

* Remove vue-append #220

* Update to web3 1.3.5 and sass-loader 10.1.1 #220

* Use go-ethereum v1.9.25 #214

* Revert go-ethereum v1.9.25

* Detect window.ethereum (#203)

* Update docker readme

* Fix settings API keys encryption overwrite

* Ran make all

* Replaced node-sass by sass #236

* Fix SASS division warnings

* vue-cli updated to 4.5.15 & minor delinting

* Added vue-append, core-js; enabled errors shown in ui build

* Vue deep selector syntax

* Added gitpod config, added .env to gitignore, minor mod update

* Updated vue-pdf

* Delinted Document vues

* Ignore all static libs from eslint

* Vue entrypoints delinted

* Views delinted

* Vue entrypoints delinted

* Refactor language list in preview

* Template and PDF Modal views

* Views delinted

* ImexResults delinted/ignored

* Fixed ui issues in testing

Co-authored-by: Mehdy javany <[email protected]>
@loleg loleg added backend Pull requests that update Go code and removed enhancement New feature or request labels Jan 5, 2022
@loleg
Copy link
Contributor Author

loleg commented Feb 16, 2023

Not a high priority, but still would be good to upgrade to v4 in the near future.

@loleg loleg moved this to Todo in Maintenance - Q1 2024 Aug 11, 2023
@loleg
Copy link
Contributor Author

loleg commented Oct 13, 2023 •
edited
Loading

I'm often having a "blank screen" - mystery echo 404 - issue, this would be great to prioritize and at least make it possible to debug this kind of problem with the backend views / controller.

@loleg loleg moved this from Todo to In Progress in Maintenance - Q1 2024 Oct 13, 2023
@loleg loleg moved this from In Progress to Agreed for Dev in Maintenance - Q1 2024 Oct 13, 2023
@loleg
Copy link
Contributor Author

loleg commented Oct 16, 2023

There's a discussion of the upgrade path to v4 here.

Otherwise, I have not found anything in the docs or CHANGELOG.

@loleg loleg mentioned this issue Oct 16, 2023
Merged
@loleg loleg moved this from Agreed for Dev to In Progress in Maintenance - Q1 2024 Oct 20, 2023
@loleg loleg mentioned this issue Nov 16, 2023
Open
@loleg loleg moved this from In Progress to Agreed for Dev in Maintenance - Q1 2024 Nov 18, 2023
@loleg loleg moved this from Agreed for Dev to In Progress in Maintenance - Q1 2024 Dec 22, 2023
@loleg loleg moved this from In Progress to In testing in Maintenance - Q1 2024 Jan 11, 2024
@loleg loleg moved this from In testing to In Progress in Maintenance - Q1 2024 Jan 11, 2024
@loleg loleg mentioned this issue Jan 26, 2024
Merged
@loleg loleg closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loleg loleg

Labels
backend Pull requests that update Go code
Projects
No open projects
Maintenance sprint - Q1 2023
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@loleg @slavas490