Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask deprecation warning #199

Closed
loleg opened this issue Dec 18, 2020 · 2 comments
Closed

Metamask deprecation warning #199

loleg opened this issue Dec 18, 2020 · 2 comments
Labels
incomplete Issue needs additional information

Comments

@loleg
Copy link
Contributor

loleg commented Dec 18, 2020

On a newly deployed server or on the demo instance, Metamask throws a warning as follows:

inpage.js:1 MetaMask: We will stop injecting web3 in Q4 2020.

Please see this article for more information: https://medium.com/metamask/no-longer-injecting-web3-js-4a899ad6e59e

Developer documentation is at https://docs.metamask.io/guide/ethereum-provider.html#upcoming-breaking-changes and https://metamask.zendesk.com/hc/en-us/articles/360053147012

The web3.js library is already one of the dependencies in core/ui, but we may need to update the way we initialise it. See WalletInterface.js and related issue #23 and #190

This may be just a warning that we need to keep an eye on. I don't see an option in my Metamask extension to disable web3 injection, and after reading the code there does not seem to be any cause for alarm.

@loleg loleg added the incomplete Issue needs additional information label Dec 18, 2020
@loleg
Copy link
Contributor Author

loleg commented Dec 18, 2020

See also my branch metamask-Q42020 for some attempts to improve web3 initialisation.

@loleg loleg mentioned this issue Jan 21, 2021
10 tasks
@loleg
Copy link
Contributor Author

loleg commented Mar 24, 2021

Closing for now, as #203 should have addressed this.

@loleg loleg closed this as completed Mar 24, 2021
loleg added a commit to loleg/proxeus-core that referenced this issue Mar 24, 2021
loleg added a commit to loleg/proxeus-core that referenced this issue Mar 24, 2021
loleg added a commit to loleg/proxeus-core that referenced this issue Mar 24, 2021
loleg added a commit that referenced this issue Apr 30, 2021
* Refactored start docs

* Changed source of go-bindata #197

* Updated go dep trackers

* Updated yarn dependencies

* Added update step to Makefile

* New auto-generated bindata tests

* Added doc note about make update

* yarn upgrade

* Doc: rename Infura key as "project ID" for clarity

* Set resource class to medium for CircleCI builds

* Use Debian 'stable' release in Docker

* Add .env configuration loader to make #204

* Copy env during bootstrap

* Documentation related to license finder

* go-bindata install path

* Docker documentation link

* README revised

* Added logging instruction

* Dependency updates, tidy and fix #213

* Documentation tips added

* Yarn update

* Added versioned ssri & is-svg to ui/core

* File type to sync Map #215

* echo-contrib locked to echo v3 #216

* Fix make circular dependency on bindata.go warning

* Switch to CircleCI next gen image #202

* Skip compilation in cloud deploy

* Update to Go 1.16 #217

* Fixed go-bindata install

* Better test for window.web3 #199

* Reverted to legacy CircleCI image

* Revert to new image and new go-bindata load strategy #202

* Fix use of mongo.IndexModel #218

* Update to Node.js LTS 14.x #217

* Improve test for window.web3 #199

* Use same image for build-ui #217

* Updated ui library web3 1.3.4 #199

* Go mod tidy
loleg added a commit that referenced this issue Dec 10, 2021
* Refactored start docs

* Changed source of go-bindata #197

* Updated go dep trackers

* Updated yarn dependencies

* Added update step to Makefile

* New auto-generated bindata tests

* Added doc note about make update

* yarn upgrade

* Doc: rename Infura key as "project ID" for clarity

* Set resource class to medium for CircleCI builds

* Use Debian 'stable' release in Docker

* Add .env configuration loader to make #204

* Copy env during bootstrap

* Documentation related to license finder

* go-bindata install path

* Docker documentation link

* README revised

* Added logging instruction

* Dependency updates, tidy and fix #213

* Documentation tips added

* Yarn update

* Added versioned ssri & is-svg to ui/core

* File type to sync Map #215

* echo-contrib locked to echo v3 #216

* Fix make circular dependency on bindata.go warning

* Switch to CircleCI next gen image #202

* Skip compilation in cloud deploy

* Update to Go 1.16 #217

* Fixed go-bindata install

* Better test for window.web3 #199

* Reverted to legacy CircleCI image

* Revert to new image and new go-bindata load strategy #202

* Fix use of mongo.IndexModel #218

* Update to Node.js LTS 14.x #217

* Improve test for window.web3 #199

* Use same image for build-ui #217

* Updated ui library web3 1.3.4 #199

* Go mod tidy

* Minor ui linting fix

* Go library upgrade: mongo-driver, goja

* Upgrade @vue/cli-service from 3.12.1 to 4.5.12

* Auto-conversion to ES6 syntax #220

* Switch cli to dev dependencies

* Remove eth-lightwallet #220

* Remove vue-append #220

* Update to web3 1.3.5 and sass-loader 10.1.1 #220

* Use go-ethereum v1.9.25 #214

* Revert go-ethereum v1.9.25

* Detect window.ethereum (#203)

* Update docker readme

* Fix settings API keys encryption overwrite

* Ran make all

* Replaced node-sass by sass #236

* Fix SASS division warnings

* vue-cli updated to 4.5.15 & minor delinting

* Added vue-append, core-js; enabled errors shown in ui build

* Vue deep selector syntax

* Added gitpod config, added .env to gitignore, minor mod update

* Updated vue-pdf

* Delinted Document vues

* Ignore all static libs from eslint

* Vue entrypoints delinted

* Views delinted

* Vue entrypoints delinted

* Refactor language list in preview

* Template and PDF Modal views

* Views delinted

* ImexResults delinted/ignored

* Fixed ui issues in testing

Co-authored-by: Mehdy javany <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incomplete Issue needs additional information
Projects
None yet
Development

No branches or pull requests

1 participant