Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make update fails on urfave module #213

Closed
loleg opened this issue Mar 24, 2021 · 2 comments
Closed

Make update fails on urfave module #213

loleg opened this issue Mar 24, 2021 · 2 comments

Comments

@loleg
Copy link
Contributor

loleg commented Mar 24, 2021

After running make update I get an error:

go get all: gopkg.in/urfave/[email protected]: invalid version: go.mod has non-....v1 module path "github.com/urfave/cli" at revision v1.22.5
make: *** [Makefile:83: update] Error 1

This seems to be a mismatched import of https://github.com/urfave/cli on the https://github.com/ethereum/go-ethereum package.
@loleg
Copy link
Contributor Author

loleg commented Mar 24, 2021 •
edited
Loading

This is a similar issue to urfave/cli#904
I first explored the dependency graph with go mod graph | grep urfave.
Fixed in go.mod by adding:

require gopkg.in/urfave/cli.v1 v1.22.5
replace gopkg.in/urfave/cli.v1 => github.com/urfave/cli v1.22.5

@loleg loleg closed this as completed Mar 24, 2021
@loleg
Copy link
Contributor Author

loleg commented Mar 24, 2021 •
edited
Loading

I fixed a similar issue with httpexpect.v2 (see gavv/httpexpect#60)

loleg added a commit to loleg/proxeus-core that referenced this issue Mar 24, 2021
@loleg
Dependency updates, tidy and fix ProxeusApp#213
56c4f96
@loleg loleg mentioned this issue Mar 24, 2021
Merged
loleg added a commit that referenced this issue Apr 30, 2021
@loleg
Update Go-Ethereum (#214)
3994324 
* Refactored start docs

* Changed source of go-bindata #197

* Updated go dep trackers

* Updated yarn dependencies

* Added update step to Makefile

* New auto-generated bindata tests

* Added doc note about make update

* yarn upgrade

* Doc: rename Infura key as "project ID" for clarity

* Set resource class to medium for CircleCI builds

* Use Debian 'stable' release in Docker

* Add .env configuration loader to make #204

* Copy env during bootstrap

* Documentation related to license finder

* go-bindata install path

* Docker documentation link

* README revised

* Added logging instruction

* Dependency updates, tidy and fix #213

* Documentation tips added

* Yarn update

* Added versioned ssri & is-svg to ui/core

* File type to sync Map #215

* echo-contrib locked to echo v3 #216

* Fix make circular dependency on bindata.go warning

* Switch to CircleCI next gen image #202

* Skip compilation in cloud deploy

* Update to Go 1.16 #217

* Fixed go-bindata install

* Better test for window.web3 #199

* Reverted to legacy CircleCI image

* Revert to new image and new go-bindata load strategy #202

* Fix use of mongo.IndexModel #218

* Update to Node.js LTS 14.x #217

* Improve test for window.web3 #199

* Use same image for build-ui #217

* Updated ui library web3 1.3.4 #199

* Go mod tidy
loleg added a commit that referenced this issue Dec 10, 2021
@loleg @m-javani
Frontend build upgrade (#237)
5f6dfd2 
* Refactored start docs

* Changed source of go-bindata #197

* Updated go dep trackers

* Updated yarn dependencies

* Added update step to Makefile

* New auto-generated bindata tests

* Added doc note about make update

* yarn upgrade

* Doc: rename Infura key as "project ID" for clarity

* Set resource class to medium for CircleCI builds

* Use Debian 'stable' release in Docker

* Add .env configuration loader to make #204

* Copy env during bootstrap

* Documentation related to license finder

* go-bindata install path

* Docker documentation link

* README revised

* Added logging instruction

* Dependency updates, tidy and fix #213

* Documentation tips added

* Yarn update

* Added versioned ssri & is-svg to ui/core

* File type to sync Map #215

* echo-contrib locked to echo v3 #216

* Fix make circular dependency on bindata.go warning

* Switch to CircleCI next gen image #202

* Skip compilation in cloud deploy

* Update to Go 1.16 #217

* Fixed go-bindata install

* Better test for window.web3 #199

* Reverted to legacy CircleCI image

* Revert to new image and new go-bindata load strategy #202

* Fix use of mongo.IndexModel #218

* Update to Node.js LTS 14.x #217

* Improve test for window.web3 #199

* Use same image for build-ui #217

* Updated ui library web3 1.3.4 #199

* Go mod tidy

* Minor ui linting fix

* Go library upgrade: mongo-driver, goja

* Upgrade @vue/cli-service from 3.12.1 to 4.5.12

* Auto-conversion to ES6 syntax #220

* Switch cli to dev dependencies

* Remove eth-lightwallet #220

* Remove vue-append #220

* Update to web3 1.3.5 and sass-loader 10.1.1 #220

* Use go-ethereum v1.9.25 #214

* Revert go-ethereum v1.9.25

* Detect window.ethereum (#203)

* Update docker readme

* Fix settings API keys encryption overwrite

* Ran make all

* Replaced node-sass by sass #236

* Fix SASS division warnings

* vue-cli updated to 4.5.15 & minor delinting

* Added vue-append, core-js; enabled errors shown in ui build

* Vue deep selector syntax

* Added gitpod config, added .env to gitignore, minor mod update

* Updated vue-pdf

* Delinted Document vues

* Ignore all static libs from eslint

* Vue entrypoints delinted

* Views delinted

* Vue entrypoints delinted

* Refactor language list in preview

* Template and PDF Modal views

* Views delinted

* ImexResults delinted/ignored

* Fixed ui issues in testing

Co-authored-by: Mehdy javany <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loleg