Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade backend to echo v4 #388

Merged
merged 44 commits into from
Jan 12, 2024
Merged

Upgrade backend to echo v4 #388

merged 44 commits into from
Jan 12, 2024

Conversation

loleg
Copy link
Contributor

@loleg loleg commented Oct 16, 2023

Updating the echo framework is a major upgrade from v3 to v4.

See details in #216

@loleg
Copy link
Contributor Author

loleg commented Oct 18, 2023

Not building due to this issue at the moment during make init validate:

go: downloading golang.org/x/sys v0.13.0
go install github.com/wadey/gocovmerge
no required module provides package github.com/wadey/gocovmerge; to add it:
        go get github.com/wadey/gocovmerge
make: *** [Makefile:84: init] Error 1

@loleg loleg changed the title Backend echo v4 Backend echo v4 (PR - WIP) Nov 18, 2023
@loleg loleg self-assigned this Nov 18, 2023
@loleg
Copy link
Contributor Author

loleg commented Dec 19, 2023

Quite sure my issue has to do with this:

if strings.ToLower(c.Request().Method) == "get" {

@loleg loleg changed the title Backend echo v4 (PR - WIP) Upgrade backend to echo v4 Jan 11, 2024
@loleg loleg requested a review from tafonina January 11, 2024 13:42
@loleg
Copy link
Contributor Author

loleg commented Jan 11, 2024

All tests passing. I'm doing some additional local validation.

Copy link
Contributor

@tafonina tafonina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only thing - be sure that the data is read from env file without manual export as was specified in the build_all.md file

@loleg loleg merged commit fec36c0 into ProxeusApp:preprod Jan 12, 2024
9 checks passed
@loleg loleg deleted the backend-echo-v4 branch January 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants