Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate for 0.4.0 #59

Merged
merged 90 commits into from
Oct 6, 2024
Merged

Candidate for 0.4.0 #59

merged 90 commits into from
Oct 6, 2024

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Sep 10, 2024

Changes

Added

  1. Added orthofinder_annotations param
  2. Added FASTA_GFF_ORTHOFINDER sub-workflow
  3. Added evaluation by BUSCO #41
  4. Included common tax ids for eggnog mapper #27
  5. Implemented hierarchical naming scheme: geneI.tJ, geneI.tJ.exonK, geneI.tJ.cdsK #19, #34
  6. Now sorting list of bam and list of fastq before cat to avoid resume cache misses
  7. Allowed BAM files for RNA evidence #3
  8. Added GXF_FASTA_AGAT_SPADDINTRONS_SPEXTRACTSEQUENCES sub-workflow for splice type statistics #11
  9. Changed orthofinder_annotations from FASTA/GFF to protein FASTA #43
  10. Added param enforce_full_intron_support to turn on/off strict model purging by TSEBRA #21
  11. Added param filter_liftoff_by_hints to evaluate liftoff models with TSEBRA to make sure they have the same level of evidence as BRAKER #28
  12. Added a script to automatically check module version updates
  13. Reduced BRAKER3 threads to 8 #55
  14. Now the final annotations are stored in the annotations folder #53
  15. Now a single fasta file can be directly specified for protein_evidence
  16. eggnogmapper_db_dir is not a required parameter anymore
  17. eggnogmapper_tax_scope is now set to 1 (root div) by default
  18. Added a test profile based on public data
  19. Added parameter add_attrs_to_proteins_fasta to enable/disable addition of decoded gff attributes to proteins fasta #58
  20. Added a check for input assemblies. If an assembly is smaller than 1 MB (or 300KB in zipped format), the pipeline errors out before starting the downstream processes #47
  21. Now REPEATMASKER GFF output is saved via CUSTOM_RMOUTTOGFF3 #54
  22. Added benchmark column to the input sheet and used GFFCOMPARE to perform benchmarking #63
  23. Added SEQKIT_RMDUP to detect duplicate sequence and wrap the fasta to 80 characters
  24. Updated parameter section labels for annotation and post-annotation filtering #64
  25. Updated modules and sub-workflows

Fixed

  1. Fixed BRAKER spellings #36
  2. Fixed liftoff failure when lifting off from a single reference #40
  3. Added versions from GFF_STORE sub-workflows #33

Dependencies

  1. NextFlow!>=23.04.4
  2. nf-validation=1.1.3

Deprecated

  1. Renamed external_protein_fastas param to protein_evidence
  2. Renamed fastq param to rna_evidence
  3. Renamed braker_allow_isoforms param to allow_isoforms
  4. Moved liftoffID from gene level to mRNA/transcript level
  5. Moved version_check.sh to .github/version_checks.sh
  6. Removed dependency on https://github.com/kherronism/nf-modules.git for BRAKER3 and REPEATMASKER modules which are now installed from https://github.com/GallVp/nxf-components.git
  7. Removed dependency on https://github.com/PlantandFoodResearch/nxf-modules.git
  8. Now the final annotations are not stored in the final folder
  9. Now BRAKER3 outputs are not saved by default #53 and saved under etc folder when enabled
  10. Removed local profile. Local executor is the default when no executor is specified. Therefore, the local profile was not needed.
  11. Removed CUSTOM_DUMPSOFTWAREVERSIONS

GallVp added 30 commits June 19, 2024 12:16
@GallVp GallVp marked this pull request as draft September 13, 2024 05:19
@GallVp GallVp marked this pull request as ready for review October 4, 2024 04:13
@GallVp GallVp merged commit 24a8f50 into main Oct 6, 2024
9 checks passed
Copy link

github-actions bot commented Oct 6, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0acb62b

+| ✅ 153 tests passed       |+
#| ❔  24 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 0.4.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-genepal_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genepal_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genepal_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: assets/multiqc_config.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • nextflow_config - Config default ignored: params.ribo_database_manifest
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: assets/nf-core-genepal_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-genepal_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-genepal_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/genepal/genepal/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-10-04 04:14:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant