Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add deneb as default #2734

Merged
merged 21 commits into from
Dec 13, 2023
Merged

core: add deneb as default #2734

merged 21 commits into from
Dec 13, 2023

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Nov 30, 2023

Add a switch case for deneb fork version wherever required. Also add relevant tests.

This makes deneb the default block version as beaconmock now uses deneb by default. This ensures all tests use deneb going forward.

category: feature
ticket: #2729

@xenowits xenowits self-assigned this Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 147 lines in your changes are missing coverage. Please review.

Comparison is base (62e4d58) 53.35% compared to head (1759dc3) 53.37%.
Report is 10 commits behind head on main.

Files Patch % Lines
app/eth2wrap/synthproposer.go 0.00% 55 Missing ⚠️
core/validatorapi/router.go 58.73% 19 Missing and 7 partials ⚠️
app/log/config.go 37.50% 22 Missing and 3 partials ⚠️
cmd/createcluster.go 60.97% 12 Missing and 4 partials ⚠️
eth2util/network.go 68.08% 15 Missing ⚠️
app/app.go 0.00% 4 Missing ⚠️
core/fetcher/fetcher.go 0.00% 4 Missing ⚠️
app/monitoringapi.go 50.00% 1 Missing ⚠️
core/scheduler/scheduler.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2734      +/-   ##
==========================================
+ Coverage   53.35%   53.37%   +0.02%     
==========================================
  Files         199      199              
  Lines       27397    27605     +208     
==========================================
+ Hits        14618    14735     +117     
- Misses      10969    11051      +82     
- Partials     1810     1819       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xenowits xenowits changed the title core: add case for deneb core: add deneb as default Nov 30, 2023
Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Can you check why integration tests are failing?

@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Dec 12, 2023
gsora and others added 14 commits December 12, 2023 15:54
Write debug logs on disk if `--log-output-path` is specified.

Log files are rotated automatically once the file size reaches 50MB.

Rotated log files will be kept for 7 days - max 10 rotated files will be kept, whatever comes first.

category: feature
ticket: #2671
Adds a check for activation epoch to filter active validators before resolving duties.

category: bug
ticket: #2721
Adds custom testnet flags to `charon create cluster` and `charon run` commands.

category: feature
ticket: #2690
Removes feature flags from feature set with stable status.

category: misc
ticket: #2720
As part of recent go-eth2-client upgrade, `ProposerDuties` and `AttesterDuties` calls started to return Metadata fields: 
```
  "dependent_root": "0xc01a8003a974cea31fd9e91c7d2cec8120ea3cc71edcbb836b6fbede6c289a69",
  "execution_optimistic": false,
```

This change updates the corresponding handlers of validator API to properly parse and propagate these new fields. 

category: feature
ticket: #2736
The previous build failed due to older go version (1.21.4), now bumped to 1.21.5.

category: fixbuild
ticket: none
go-eth2-client handles `dependent_root` metadata as a special case and produces a `Root` object rather than hex string.
  
https://github.com/attestantio/go-eth2-client/blob/a05485e0e75749f2b6912db2972a35ec2ec37c3b/http/json.go#L32C25-L32C25

category: bug
ticket: #2736
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
5.5% Duplication on New Code

See analysis details on SonarCloud

@obol-bulldozer obol-bulldozer bot merged commit ad79ed6 into main Dec 13, 2023
13 checks passed
@obol-bulldozer obol-bulldozer bot deleted the xenowits/deneb-final branch December 13, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants