Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump go version to 1.21.5 #2746

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Dec 11, 2023

The previous build failed due to older go version (1.21.4), now bumped to 1.21.5.

category: fixbuild
ticket: none

@pinebit pinebit requested review from gsora, dB2510 and xenowits December 11, 2023 11:33
Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xenowits xenowits changed the title Bumped go version to 1.21.5 *: bump go version to 1.21.5 Dec 11, 2023
Copy link
Contributor

@xenowits xenowits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pinebit pinebit self-assigned this Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72c80c7) 53.29% compared to head (8e80736) 53.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2746      +/-   ##
==========================================
+ Coverage   53.29%   53.32%   +0.03%     
==========================================
  Files         199      199              
  Lines       27533    27533              
==========================================
+ Hits        14673    14682       +9     
+ Misses      11038    11028      -10     
- Partials     1822     1823       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Dec 11, 2023
@obol-bulldozer obol-bulldozer bot merged commit 58da9d0 into main Dec 11, 2023
16 of 17 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/bumping-go-version branch December 11, 2023 12:21
xenowits pushed a commit that referenced this pull request Dec 12, 2023
The previous build failed due to older go version (1.21.4), now bumped to 1.21.5.

category: fixbuild
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants